You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/03 11:45:17 UTC
[GitHub] [spark] martin-g commented on a diff in pull request #36433: [SPARK-36462][K8S] Add the ability to selectively disable watching or polling
martin-g commented on code in PR #36433:
URL: https://github.com/apache/spark/pull/36433#discussion_r863687558
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -463,6 +463,25 @@ private[spark] object Config extends Logging {
.checkValue(interval => interval > 0, s"Logging interval must be a positive time value.")
.createWithDefaultString("1s")
+ val KUBERNETES_EXECUTOR_ENABLE_API_POLLING =
+ ConfigBuilder("spark.kubernetes.executor.enableApiPolling")
+ .doc("If Spark should poll Kubernetes for executor pod status. " +
+ "You should leave this enabled unless your encountering performance issues with your etcd.")
Review Comment:
```suggestion
"You should leave this enabled unless your encountering performance issues with your etcd.")
```
```suggestion
"You should leave this enabled unless you're encountering performance issues with your etcd.")
```
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala:
##########
@@ -463,6 +463,25 @@ private[spark] object Config extends Logging {
.checkValue(interval => interval > 0, s"Logging interval must be a positive time value.")
.createWithDefaultString("1s")
+ val KUBERNETES_EXECUTOR_ENABLE_API_POLLING =
+ ConfigBuilder("spark.kubernetes.executor.enableApiPolling")
+ .doc("If Spark should poll Kubernetes for executor pod status. " +
+ "You should leave this enabled unless your encountering performance issues with your etcd.")
+ .version("3.3.0")
+ .booleanConf
+ .internal()
+ .createWithDefault(true)
+
+ val KUBERNETES_EXECUTOR_ENABLE_API_WATCHER =
+ ConfigBuilder("spark.kubernetes.executor.enableApiWatcher")
+ .doc("If Spark should create watchers for executor pod status. " +
+ "You should leave this enabled unless your encountering performance issues with your etcd.")
Review Comment:
```suggestion
"You should leave this enabled unless you're encountering performance issues with your etcd.")
```
##########
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsWatchSnapshotSourceSuite.scala:
##########
@@ -61,17 +63,27 @@ class ExecutorPodsWatchSnapshotSourceSuite extends SparkFunSuite with BeforeAndA
when(appIdLabeledPods.withLabel(SPARK_ROLE_LABEL, SPARK_POD_EXECUTOR_ROLE))
.thenReturn(executorRoleLabeledPods)
when(executorRoleLabeledPods.watch(watch.capture())).thenReturn(watchConnection)
- watchSourceUnderTest = new ExecutorPodsWatchSnapshotSource(
- eventQueue, kubernetesClient)
- watchSourceUnderTest.start(TEST_SPARK_APP_ID)
}
test("Watch events should be pushed to the snapshots store as snapshot updates.") {
+ val conf = new SparkConf()
+ watchSourceUnderTest = new ExecutorPodsWatchSnapshotSource(
+ eventQueue, kubernetesClient, conf)
+ watchSourceUnderTest.start(TEST_SPARK_APP_ID)
val exec1 = runningExecutor(1)
val exec2 = runningExecutor(2)
watch.getValue.eventReceived(Action.ADDED, exec1)
watch.getValue.eventReceived(Action.MODIFIED, exec2)
verify(eventQueue).updatePod(exec1)
verify(eventQueue).updatePod(exec2)
}
+
+ test("Verify if watchers are disabled we don't call pods() on the client") {
Review Comment:
```suggestion
test("SPARK-36462: Verify if watchers are disabled we don't call pods() on the client") {
```
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsWatchSnapshotSource.scala:
##########
@@ -38,19 +40,23 @@ import org.apache.spark.util.Utils
@DeveloperApi
class ExecutorPodsWatchSnapshotSource(
snapshotsStore: ExecutorPodsSnapshotsStore,
- kubernetesClient: KubernetesClient) extends Logging {
+ kubernetesClient: KubernetesClient,
+ conf: SparkConf) extends Logging {
private var watchConnection: Closeable = _
+ private val enablePolling = conf.get(KUBERNETES_EXECUTOR_ENABLE_API_WATCHER)
@Since("3.1.3")
def start(applicationId: String): Unit = {
- require(watchConnection == null, "Cannot start the watcher twice.")
- logDebug(s"Starting watch for pods with labels $SPARK_APP_ID_LABEL=$applicationId," +
- s" $SPARK_ROLE_LABEL=$SPARK_POD_EXECUTOR_ROLE.")
- watchConnection = kubernetesClient.pods()
- .withLabel(SPARK_APP_ID_LABEL, applicationId)
- .withLabel(SPARK_ROLE_LABEL, SPARK_POD_EXECUTOR_ROLE)
- .watch(new ExecutorPodsWatcher())
+ if (enablePolling) {
+ require(watchConnection == null, "Cannot start the watcher twice.")
+ logDebug(s"Starting watch for pods with labels $SPARK_APP_ID_LABEL=$applicationId," +
Review Comment:
```suggestion
logDebug(s"Starting to watch for pods with labels $SPARK_APP_ID_LABEL=$applicationId," +
```
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsWatchSnapshotSource.scala:
##########
@@ -38,19 +40,23 @@ import org.apache.spark.util.Utils
@DeveloperApi
class ExecutorPodsWatchSnapshotSource(
snapshotsStore: ExecutorPodsSnapshotsStore,
- kubernetesClient: KubernetesClient) extends Logging {
+ kubernetesClient: KubernetesClient,
+ conf: SparkConf) extends Logging {
private var watchConnection: Closeable = _
+ private val enablePolling = conf.get(KUBERNETES_EXECUTOR_ENABLE_API_WATCHER)
Review Comment:
`enableWatching` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org