You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/11/03 08:32:57 UTC

[GitHub] rahul003 commented on a change in pull request #8294: NCCL integration

rahul003 commented on a change in pull request #8294: NCCL integration
URL: https://github.com/apache/incubator-mxnet/pull/8294#discussion_r148691972
 
 

 ##########
 File path: src/kvstore/comm.h
 ##########
 @@ -32,6 +35,21 @@
 #include "mxnet/ndarray.h"
 #include "../ndarray/ndarray_function.h"
 #include "../operator/tensor/sparse_retain-inl.h"
+
+#if MXNET_USE_NCCL
 
 Review comment:
   Can't we merge the two ```#if MXNET_USE_NCCL ```?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services