You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/18 10:11:33 UTC
[GitHub] tillrohrmann commented on a change in pull request #6816:
[FLINK-10527] Cleanup constant isNewMode in YarnTestBase
tillrohrmann commented on a change in pull request #6816: [FLINK-10527] Cleanup constant isNewMode in YarnTestBase
URL: https://github.com/apache/flink/pull/6816#discussion_r226247002
##########
File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YarnTestBase.java
##########
@@ -151,8 +151,6 @@
protected org.apache.flink.configuration.Configuration flinkConfiguration;
- protected final boolean isNewMode = true;
Review comment:
I would suggest to not remove this field until we have ported all test cases. Then, we would not have to add the `@Ignore` statements.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services