You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Filip Miletic (JIRA)" <ji...@apache.org> on 2009/04/10 20:17:14 UTC
[jira] Created: (SHINDIG-1011) Proxied image resizing
Proxied image resizing
----------------------
Key: SHINDIG-1011
URL: https://issues.apache.org/jira/browse/SHINDIG-1011
Project: Shindig
Issue Type: New Feature
Components: Java
Affects Versions: trunk
Reporter: Filip Miletic
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-1011) Proxied image resizing
Posted by "Paul Lindner (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12697902#action_12697902 ]
Paul Lindner commented on SHINDIG-1011:
---------------------------------------
that's my dog :)
> Proxied image resizing
> ----------------------
>
> Key: SHINDIG-1011
> URL: https://issues.apache.org/jira/browse/SHINDIG-1011
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: trunk
> Reporter: Filip Miletic
> Attachments: dog.gif, shindig-proxied-image-resizing.diff
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1011) Proxied image resizing
Posted by "Filip Miletic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Miletic updated SHINDIG-1011:
-----------------------------------
Attachment: dog.gif
The image used to test the resizing. svn diff would not include it in the patch so I'm putting it up like this.
I don't know whose image this is, and if it is copyrighted. It's a nice dog though.
> Proxied image resizing
> ----------------------
>
> Key: SHINDIG-1011
> URL: https://issues.apache.org/jira/browse/SHINDIG-1011
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: trunk
> Reporter: Filip Miletic
> Attachments: dog.gif, shindig-proxied-image-resizing.diff
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1011) Proxied image resizing
Posted by "Filip Miletic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Miletic updated SHINDIG-1011:
-----------------------------------
Attachment: shindig-proxied-image-resizing-2.patch
Updated patch, fixes the test failures.
> Proxied image resizing
> ----------------------
>
> Key: SHINDIG-1011
> URL: https://issues.apache.org/jira/browse/SHINDIG-1011
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: trunk
> Reporter: Filip Miletic
> Attachments: dog.gif, shindig-proxied-image-resizing-2.patch, shindig-proxied-image-resizing.diff
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (SHINDIG-1011) Proxied image resizing
Posted by "Filip Miletic (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Miletic updated SHINDIG-1011:
-----------------------------------
Attachment: shindig-proxied-image-resizing.diff
Corrections after the second round of code review.
o Reinforce the image rewriter tests.
o Corrected the parameter reading.
o Ignore the unusable parameters.
o Modifies getOwnerId() and related methods
The old behavior of AbstractHttpCache.getOwnerId() was to return
ownerId as-is. Since ownerId may be null, this amounted to inserting
a literal "null" in the cache key. As we probably don't want that
(it's colliding with the owner id which in fact is "null"), the
getOwnerId(HttpRequest) now returns an empty string literal for a null
owner ID.
The code and cleanup to support proxied image resizing.
Based on the initial work of Paul Lindner of Hi5. His work in turn is
based on further contributions, but I don't know at present which ones.
o Reorganized the image rewriter implementation from Paul, and corrected
a few bugs in the image dimensions computation.
o A few readability changes.
o Verified new behavior and added the tests to guard against accidental
further behavior changes.
o Modified the caching policy to take into account the resizing URL
arguments required for resizing to work.
o Factored the cache key building into a builder class that ensures
backward compatibility of the generated cache keys, and makes building
cache keys easier in general.
o Added the tests to guard against accidental behavior changes in the
cache key builder.
o Fitted all the pieces back together again.
> Proxied image resizing
> ----------------------
>
> Key: SHINDIG-1011
> URL: https://issues.apache.org/jira/browse/SHINDIG-1011
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: trunk
> Reporter: Filip Miletic
> Attachments: shindig-proxied-image-resizing.diff
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SHINDIG-1011) Proxied image resizing
Posted by "Adam Winer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Adam Winer resolved SHINDIG-1011.
---------------------------------
Resolution: Fixed
Patch was checked in.
> Proxied image resizing
> ----------------------
>
> Key: SHINDIG-1011
> URL: https://issues.apache.org/jira/browse/SHINDIG-1011
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: trunk
> Reporter: Filip Miletic
> Attachments: dog.gif, shindig-proxied-image-resizing-2.patch, shindig-proxied-image-resizing.diff
>
> Original Estimate: 0.17h
> Remaining Estimate: 0.17h
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.