[jira] [Commented] (DERBY-6526) Document the MERGE statement

["Rick Hillegas (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-6526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13955411#comment-13955411 ] 

Rick Hillegas commented on DERBY-6526:
--------------------------------------

Thanks for the patch, Kim. A couple comments:

rrefkeywords29722:

o MERGE and MATCHED are non-reserved keywords, so they should not appear in this list.

o While I was in there, I discovered some other problems with this page:

  OVER and ROW_NUMBER are non-reserved too, so they shouldn't appear in this list

  CHARACTER_LENGTH and LEADING are reserved keywords which should appear in this list



rrefsqljmerge

o I see that the functional spec incorrectly describes the restrictions on identity and generated columns. I will update the spec to say this: INSERT column lists may not mention identity columns. In a VALUES clause, DEFAULT is the only value allowed for generated columns. On the right side of SET operators for UPDATE actions, DEFAULT is the only value allowed for generated and identity columns.

o I think it would be good to state somewhere that the row count for a successful MERGE statement is the total number of rows inserted, updated, and deleted by the statement.

Thanks
-Rick


> Document the MERGE statement
> ----------------------------
>
>                 Key: DERBY-6526
>                 URL: https://issues.apache.org/jira/browse/DERBY-6526
>             Project: Derby
>          Issue Type: Improvement
>          Components: Documentation
>    Affects Versions: 10.11.0.0
>            Reporter: Rick Hillegas
>            Assignee: Kim Haase
>         Attachments: DERBY-6526.diff, DERBY-6526.stat, DERBY-6526.zip
>
>
> The MERGE statement is ready to be documented. Hopefully, the functional spec attached to DERBY-3155 is complete enough for this task.



--
This message was sent by Atlassian JIRA
(v6.2#6252)