RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/t estHeader.java HttpRequest.java

[Keith Wannamaker <Ke...@Wannamaker.org>]

Hi, David, Colin, et al.,

| > Since I'm going to need support for chunked requests in 3.3 anyway, I'm
| > going ahead with the port of my 3.2.2 changes.  I hope to have it in a
| > couple of days.
|
| The fix in Ajp13 ( java side ) should be already in, and any _small_
| fix in the java side is ok.
|
| Same for mod_jk, after a lot of review :-)

I had some reservations at some of the changes David presented, I think
the problem can be solved with a smaller code hit.  Working on it now..

| > >- Does the java part need to know that the incoming data came in CHUNKED ?
| > The Java side can figure it out if the Content-Length is not set.  Still,
| > the Content-Length might be set even when the transfer was chunked.  Not
| > sure how much value would be added in knowing this explicitly.

I don't *think* the Java side needs to be changed at all, and Costin is right,
HTTP/1.1 s 4.4 says cl cannot be set with any non-identity transfer encoding.

| > >- Should we add others HTTP/1.1 commands like Range, Accept-Ranges, CONNECT
| > >?
| > I suppose these could be helpful but I haven't thought too much about it.
| > In general, it seems like a good idea to leverage as much as possible from
| > the transport.

Um, let's get chunked encoding in first...

Keith

Re: embedded tc

[Christopher Cain <cc...@mhsoftware.com>]

Quoting Keith Wannamaker <Ke...@Wannamaker.org>:

> Could this ever happen or am I doing something silly?
> Keith

[snip]

> +       if (cp != null) {
>         System.getProperties().put("tc_path_add",cp);
> +       }

Not sure if it could possibly happen or not. Just to add my $.02 to the above, 
however, it might be good to have an "else" clause either toss a message to the 
command-line (if skipping the put() call might cause problems later on down the 
line) or write a message to log (if it's not that big of a deal).

- Christopher

/**
 * Pleurez, pleurez, mes yeux, et fondez vous en eau!
 * La moitié de ma vie a mis l'autre au tombeau.
 *    ---Cornelle
 */

embedded tc

[Keith Wannamaker <Ke...@Wannamaker.org>]

Could this ever happen or am I doing something silly?
Keith

Index: src/share/org/apache/tomcat/startup/EmbededTomcat.java
===================================================================
RCS file:
/home/cvs/jakarta-tomcat/src/share/org/apache/tomcat/startup/EmbededTomcat.java,
v
retrieving revision 1.50
diff -u -b -r1.50 EmbededTomcat.java
--- src/share/org/apache/tomcat/startup/EmbededTomcat.java      2001/08/23
15:13:47     1.50
+++ src/share/org/apache/tomcat/startup/EmbededTomcat.java      2001/08/29
00:46:50
@@ -705,7 +705,9 @@
        String cp=System.getProperty("tc_path_add");
        cp=IntrospectionUtils.classPathAdd(commonCP,cp);
        cp=IntrospectionUtils.classPathAdd(appsCP,cp);
+       if (cp != null) {
        System.getProperties().put("tc_path_add",cp);
+       }

        contextM.setParentLoader(parentCL);
        contextM.setCommonLoader(commonCL);

RE: cvs commit: jakarta-tomcat/src/share/org/apache/tomcat/util/t estHeader.java HttpRequest.java

[Keith Wannamaker <Ke...@Wannamaker.org>]

| | > >- Does the java part need to know that the incoming data came in 
| CHUNKED ?
| | > The Java side can figure it out if the Content-Length is not set.  Still,
| | > the Content-Length might be set even when the transfer was chunked.  Not
| | > sure how much value would be added in knowing this explicitly.
| 
| I don't *think* the Java side needs to be changed at all, 

Yeah, I've got chunked input working ok with just some changes to
the c side of jk.  I'll clean it up and post tomorrow for dissection.

Keith