[GitHub] [hive] asolimando commented on a change in pull request #2979: HIVE-25909 add test for nulls last property in windows

[GitBox <gi...@apache.org>]

asolimando commented on a change in pull request #2979:
URL: https://github.com/apache/hive/pull/2979#discussion_r795875749



##########
File path: parser/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
##########
@@ -863,7 +863,7 @@ import org.apache.hadoop.hive.conf.HiveConf;
   }
   protected boolean nullsLast() {
     if(hiveConf == null){
-      return false;
+      return HiveConf.ConfVars.HIVE_DEFAULT_NULLS_LAST.defaultBoolVal;

Review comment:
       Sure, I have opened a separate PR with a new JIRA ticket: https://github.com/apache/hive/pull/2990




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org