You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/03/29 16:38:00 UTC

[jira] [Commented] (WICKET-6543) onConfigure() Javadoc claims Overrides must call super, but there is no check to enforce it

    [ https://issues.apache.org/jira/browse/WICKET-6543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419315#comment-16419315 ] 

ASF subversion and git services commented on WICKET-6543:
---------------------------------------------------------

Commit 65227fb1464330213a5893be4d6bca89465abbf7 in wicket's branch refs/heads/master from [~svenmeier]
[ https://git-wip-us.apache.org/repos/asf?p=wicket.git;h=65227fb ]

WICKET-6543 verify super call for onConfigure


> onConfigure() Javadoc claims Overrides must call super, but there is no check to enforce it
> -------------------------------------------------------------------------------------------
>
>                 Key: WICKET-6543
>                 URL: https://issues.apache.org/jira/browse/WICKET-6543
>             Project: Wicket
>          Issue Type: Bug
>    Affects Versions: 8.0.0-M8
>            Reporter: Kees van Dieren
>            Priority: Minor
>             Fix For: 8.0.0
>
>
> [https://github.com/apache/wicket/blob/9e42a9548adb0da540e4e87d491f5824e778537e/wicket-core/src/main/java/org/apache/wicket/Component.java#L795] claims that: 
> {{Overrides must call \{@code super.onConfigure()}, usually before any other code}}
> However Component#onConfigure() does not set a flag (like onInitialize() does) nor does configure() check that its own onConfigure() gets called.
> As user of the framework, I would expect consistent behavior between onConfigure() and onInitialize().
> It might be a good idea to fix this before Wicket 8.0.0, as changing this behavior is a breaking change.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)