[GitHub] [incubator-doris] morningman commented on a change in pull request #3699: [Bug] Duplicate Key table core when predicate on metric column

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #3699:
URL: https://github.com/apache/incubator-doris/pull/3699#discussion_r431073031



##########
File path: be/src/olap/olap_cond.cpp
##########
@@ -651,14 +651,10 @@ bool Conditions::delete_conditions_eval(const RowCursor& row) const {
 bool Conditions::rowset_pruning_filter(const std::vector<KeyRange>& zone_maps) const {
     //通过所有列上的删除条件对version进行过滤
     for (auto& cond_it : _columns) {
-        if (_cond_column_is_key_or_duplicate(cond_it.second) && cond_it.first > zone_maps.size()) {
-            LOG(WARNING) << "where condition not equal zone maps size. "
-                         << "cond_id=" << cond_it.first
-                         << ", zone_map_size=" << zone_maps.size();
-            return false;
-        }
-        if (_cond_column_is_key_or_duplicate(cond_it.second) && !cond_it.second->eval(zone_maps.at(cond_it.first))) {
-            return true;
+        if (_cond_column_is_key_or_duplicate(cond_it.second)) {

Review comment:
       Could you please add some comment for this method. about the meaning of its return.
   And you can also modify Chinese comment to English.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org