[GitHub] [incubator-nuttx-apps] v01d commented on issue #669: LTP cannot compile correctly due to duplicate object file names

[GitBox <gi...@apache.org>]

v01d commented on issue #669:
URL: https://github.com/apache/incubator-nuttx-apps/issues/669#issuecomment-814907425


   > > A potentially problematic line could be this one in Application.mk:
   > > `.depend: Makefile $(wildcard $(foreach SRC, $(SRCS), $(addsuffix /$(SRC), $(subst :, ,$(VPATH))))) $(DEPCONFIG)`
   > > I don't really understand how VPATH is supposed to work here, is it would result in all VPATH entries appearing with each source file.
   > > Not quite sure how dependency generation should be dealt with when having external source files. In fact, I checked with nimBLE and the Make.dep is empty since it does not populate CSRCS, etc.
   > 
   > The issue here is that we need to use the full path and not just the filename and then the base path of the application directory. If I had
   > 
   > ```
   > myapp/src/1.c
   > myapp/src/libs/1.c
   > myapp/src/2.c
   > ```
   > 
   > I would have the same issue
   > With two entries like
   > 
   > ```
   > 1.full.app.dir:
   > 1.full.app.dir:
   > 2.full.app.dir:
   > ```
   
   I understand, but I was trying to come up with a fix that does this and at the same time does the right thing for NuttX's sources and couldn't think of a way. The line I highlighted uses VPATH in some way but I'm not entirely sure if it actually does anything useful. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org