You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Jake Farrell <jf...@apache.org> on 2014/06/25 18:12:02 UTC
Review Request 22956: AURORA-231: Licence plugin is noisy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22956/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Bill Farner.
Bugs: AURORA-231
https://issues.apache.org/jira/browse/AURORA-231
Repository: aurora
Description
-------
AURORA-231: Licence plugin is noisy
Upgrades license plugin to latest version which contains updates to
silence ignored headers [1].
[1]: https://github.com/hierynomus/license-gradle-plugin/pull/31
Diffs
-----
build.gradle bcecb43308a654e79db5cbd0ba973b2410b00de9
Diff: https://reviews.apache.org/r/22956/diff/
Testing
-------
./gradlew -Pq clean build
Thanks,
Jake Farrell
Re: Review Request 22956: AURORA-231: Licence plugin is noisy
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22956/#review46669
-----------------------------------------------------------
Ship it!
Review workflow pedantry, but can you change the review summary to match what is done in the diff (and let the ticket give context)? I'm thinking for when this is in the git commit log, "Licence plugin is noisy" doesn't make for an informative commit message.
- Bill Farner
On June 25, 2014, 4:12 p.m., Jake Farrell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22956/
> -----------------------------------------------------------
>
> (Updated June 25, 2014, 4:12 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-231
> https://issues.apache.org/jira/browse/AURORA-231
>
>
> Repository: aurora
>
>
> Description
> -------
>
> AURORA-231: Licence plugin is noisy
>
> Upgrades license plugin to latest version which contains updates to
> silence ignored headers [1].
>
> [1]: https://github.com/hierynomus/license-gradle-plugin/pull/31
>
>
> Diffs
> -----
>
> build.gradle bcecb43308a654e79db5cbd0ba973b2410b00de9
>
> Diff: https://reviews.apache.org/r/22956/diff/
>
>
> Testing
> -------
>
> ./gradlew -Pq clean build
>
>
> Thanks,
>
> Jake Farrell
>
>
Re: Review Request 22956: AURORA-231: Upgrade gradle license plugin to v9
which contains reduced debug output
Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22956/
-----------------------------------------------------------
(Updated June 26, 2014, 2:28 a.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Summary (updated)
-----------------
AURORA-231: Upgrade gradle license plugin to v9 which contains reduced debug output
Bugs: AURORA-231
https://issues.apache.org/jira/browse/AURORA-231
Repository: aurora
Description (updated)
-------
AURORA-231: Upgrade gradle license plugin to v9 which contains reduced debug output
Upgrades license plugin to latest version which contains updates to
silence ignored headers [1].
[1]: https://github.com/hierynomus/license-gradle-plugin/pull/31
Diffs
-----
build.gradle bcecb43308a654e79db5cbd0ba973b2410b00de9
Diff: https://reviews.apache.org/r/22956/diff/
Testing
-------
./gradlew -Pq clean build
Thanks,
Jake Farrell