You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by eo...@apache.org on 2017/07/14 10:36:25 UTC
[bookkeeper] branch master updated: y
This is an automated email from the ASF dual-hosted git repository.
eolivelli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git
The following commit(s) were added to refs/heads/master by this push:
new 8bb699e y
8bb699e is described below
commit 8bb699ed468c39e1ae1c01dd7fc02033d7b74ce2
Author: jiazhai <zh...@live.com>
AuthorDate: Fri Jul 14 12:36:07 2017 +0200
y
Descriptions of the changes in this PR:
Handle handle non-ascii chars in username in merge script.
---
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [X] Make sure the PR title is formatted like:
`<Issue # or BOOKKEEPER-#>: Description of pull request`
`e.g. Issue 123: Description ...`
`e.g. BOOKKEEPER-1234: Description ...`
- [X] Make sure tests pass via `mvn clean apache-rat:check install findbugs:check`.
- [X] Replace `<Issue # or BOOKKEEPER-#>` in the title with the actual Issue/JIRA number.
---
Author: jiazhai <zh...@live.com>
Reviewers: Enrico Olivelli <eo...@apache.org>
This closes #242 from jiazhai/issue_241
---
dev/bk-merge-pr.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dev/bk-merge-pr.py b/dev/bk-merge-pr.py
index ddeb9b4..e8f6e34 100755
--- a/dev/bk-merge-pr.py
+++ b/dev/bk-merge-pr.py
@@ -447,7 +447,7 @@ def get_reviewers(pr_num):
username = user['name'].strip()
if username is None:
continue
- reviewers_emails.append('{0} <{1}>'.format(username, useremail))
+ reviewers_emails.append('{0} <{1}>'.format(username.encode('utf8'), useremail))
return ', '.join(reviewers_emails)
def main():
--
To stop receiving notification emails like this one, please contact
['"commits@bookkeeper.apache.org" <co...@bookkeeper.apache.org>'].