You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by an...@apache.org on 2015/01/26 04:16:47 UTC
spark git commit: SPARK-4430 [STREAMING] [TEST] Apache RAT Checks
fail spuriously on test files
Repository: spark
Updated Branches:
refs/heads/master fc2168f04 -> 0528b85cf
SPARK-4430 [STREAMING] [TEST] Apache RAT Checks fail spuriously on test files
Another trivial one. The RAT failure was due to temp files from `FailureSuite` not being cleaned up. This just makes the cleanup more reliable by using the standard temp dir mechanism.
Author: Sean Owen <so...@cloudera.com>
Closes #4189 from srowen/SPARK-4430 and squashes the following commits:
9ea63ff [Sean Owen] Properly acquire a temp directory to ensure it is cleaned up at shutdown, which helps avoid a RAT check failure
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/0528b85c
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/0528b85c
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/0528b85c
Branch: refs/heads/master
Commit: 0528b85cf96f9c9c074b5fbb5b9c5dd8071c0bc7
Parents: fc2168f
Author: Sean Owen <so...@cloudera.com>
Authored: Sun Jan 25 19:16:44 2015 -0800
Committer: Andrew Or <an...@databricks.com>
Committed: Sun Jan 25 19:16:44 2015 -0800
----------------------------------------------------------------------
.../scala/org/apache/spark/streaming/FailureSuite.scala | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/0528b85c/streaming/src/test/scala/org/apache/spark/streaming/FailureSuite.scala
----------------------------------------------------------------------
diff --git a/streaming/src/test/scala/org/apache/spark/streaming/FailureSuite.scala b/streaming/src/test/scala/org/apache/spark/streaming/FailureSuite.scala
index 40434b1..6500608 100644
--- a/streaming/src/test/scala/org/apache/spark/streaming/FailureSuite.scala
+++ b/streaming/src/test/scala/org/apache/spark/streaming/FailureSuite.scala
@@ -28,21 +28,16 @@ import java.io.File
*/
class FailureSuite extends TestSuiteBase with Logging {
- var directory = "FailureSuite"
+ val directory = Utils.createTempDir().getAbsolutePath
val numBatches = 30
override def batchDuration = Milliseconds(1000)
override def useManualClock = false
- override def beforeFunction() {
- super.beforeFunction()
- Utils.deleteRecursively(new File(directory))
- }
-
override def afterFunction() {
- super.afterFunction()
Utils.deleteRecursively(new File(directory))
+ super.afterFunction()
}
test("multiple failures with map") {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org