You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by sebb <se...@gmail.com> on 2014/01/28 13:03:21 UTC

Re: svn commit: r1561504 - in /httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http: client/protocol/ conn/ssl/ impl/auth/ impl/client/ impl/conn/ impl/execchain/

On 26 January 2014 15:14,  <ol...@apache.org> wrote:
> Author: olegk
> Date: Sun Jan 26 15:14:25 2014
> New Revision: 1561504
>
> URL: http://svn.apache.org/r1561504
> Log:
> Manually edited log tags due to 23 char restriction on tag length
>
> Modified:
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/RequestAddCookiesHC4.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/RequestAuthCache.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/RequestClientConnControl.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/ResponseProcessCookiesHC4.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/conn/ssl/AbstractVerifierHC4.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/AuthenticationStrategyImpl.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/CloseableHttpClient.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/DefaultRedirectStrategy.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/InternalHttpClient.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/BasicHttpClientConnectionManager.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/CPoolEntry.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/DefaultHttpResponseParser.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/HttpClientConnectionOperator.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/InMemoryDnsResolver.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/LoggingManagedHttpClientConnection.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/ConnectionHolder.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/MainClientExec.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/MinimalClientExec.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/ProtocolExec.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/RedirectExec.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/RetryExec.java
>     httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/ServiceUnavailableRetryExec.java
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/RequestAddCookiesHC4.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/RequestAddCookiesHC4.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/RequestAddCookiesHC4.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/RequestAddCookiesHC4.java Sun Jan 26 15:14:25 2014
> @@ -67,7 +67,7 @@ import org.apache.http.util.TextUtils;
>  @Immutable
>  public class RequestAddCookiesHC4 implements HttpRequestInterceptor {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "RequestAddCookies";

Since this is now a constant, should it be changed to uppercase, i.e. TAG ?

>      public RequestAddCookiesHC4() {
>          super();
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/RequestAuthCache.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/RequestAuthCache.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/RequestAuthCache.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/RequestAuthCache.java Sun Jan 26 15:14:25 2014
> @@ -57,7 +57,7 @@ import org.apache.http.util.Args;
>  @Immutable
>  public class RequestAuthCache implements HttpRequestInterceptor {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "RequestAuthCache";
>
>      public RequestAuthCache() {
>          super();
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/RequestClientConnControl.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/RequestClientConnControl.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/RequestClientConnControl.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/RequestClientConnControl.java Sun Jan 26 15:14:25 2014
> @@ -50,7 +50,7 @@ import org.apache.http.util.Args;
>  @Immutable
>  public class RequestClientConnControl implements HttpRequestInterceptor {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "RequestConnControl";
>
>      private static final String PROXY_CONN_DIRECTIVE = "Proxy-Connection";
>
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/ResponseProcessCookiesHC4.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/ResponseProcessCookiesHC4.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/ResponseProcessCookiesHC4.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/client/protocol/ResponseProcessCookiesHC4.java Sun Jan 26 15:14:25 2014
> @@ -56,7 +56,7 @@ import org.apache.http.util.Args;
>  @Immutable
>  public class ResponseProcessCookiesHC4 implements HttpResponseInterceptor {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "ResponseProcessCookies";
>
>      public ResponseProcessCookiesHC4() {
>          super();
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/conn/ssl/AbstractVerifierHC4.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/conn/ssl/AbstractVerifierHC4.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/conn/ssl/AbstractVerifierHC4.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/conn/ssl/AbstractVerifierHC4.java Sun Jan 26 15:14:25 2014
> @@ -79,7 +79,7 @@ public abstract class AbstractVerifierHC
>          Arrays.sort(BAD_COUNTRY_2LDS);
>      }
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "AbstractVerifier";
>
>      public AbstractVerifierHC4() {
>          super();
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/auth/HttpAuthenticator.java Sun Jan 26 15:14:25 2014
> @@ -56,7 +56,7 @@ import org.apache.http.util.Asserts;
>   */
>  public class HttpAuthenticator {
>
> -       private final String tag = getClass().getSimpleName();
> +       private static final String tag = "HttpAuthenticator";
>
>      public HttpAuthenticator() {
>          super();
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/AuthenticationStrategyImpl.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/AuthenticationStrategyImpl.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/AuthenticationStrategyImpl.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/AuthenticationStrategyImpl.java Sun Jan 26 15:14:25 2014
> @@ -65,7 +65,7 @@ import org.apache.http.util.CharArrayBuf
>  @Immutable
>  abstract class AuthenticationStrategyImpl implements AuthenticationStrategy {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "AuthenticationStrategy";
>
>      private static final List<String> DEFAULT_SCHEME_PRIORITY =
>          Collections.unmodifiableList(Arrays.asList(AuthSchemes.SPNEGO,
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/CloseableHttpClient.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/CloseableHttpClient.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/CloseableHttpClient.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/CloseableHttpClient.java Sun Jan 26 15:14:25 2014
> @@ -57,7 +57,7 @@ import org.apache.http.util.EntityUtilsH
>  @ThreadSafe
>  public abstract class CloseableHttpClient implements HttpClient, Closeable {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "CloseableHttpClient";
>
>      protected abstract CloseableHttpResponse doExecute(HttpHost target, HttpRequest request,
>              HttpContext context) throws IOException, ClientProtocolException;
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/DefaultRedirectStrategy.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/DefaultRedirectStrategy.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/DefaultRedirectStrategy.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/DefaultRedirectStrategy.java Sun Jan 26 15:14:25 2014
> @@ -72,7 +72,7 @@ import org.apache.http.util.TextUtils;
>  @Immutable
>  public class DefaultRedirectStrategy implements RedirectStrategy {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "RedirectStrategy";
>
>      /**
>       * @deprecated (4.3) use {@link org.apache.http.client.protocol.HttpClientContext#REDIRECT_LOCATIONS}.
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/InternalHttpClient.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/InternalHttpClient.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/InternalHttpClient.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/client/InternalHttpClient.java Sun Jan 26 15:14:25 2014
> @@ -77,7 +77,7 @@ import org.apache.http.util.Asserts;
>  @SuppressWarnings("deprecation")
>  class InternalHttpClient extends CloseableHttpClient {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "InternalHttpClient";
>
>      private final ClientExecChain execChain;
>      private final HttpClientConnectionManager connManager;
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/BasicHttpClientConnectionManager.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/BasicHttpClientConnectionManager.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/BasicHttpClientConnectionManager.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/BasicHttpClientConnectionManager.java Sun Jan 26 15:14:25 2014
> @@ -78,7 +78,7 @@ import org.apache.http.util.LangUtils;
>  @ThreadSafe
>  public class BasicHttpClientConnectionManager implements HttpClientConnectionManager, Closeable {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "BasicConnManager";
>
>      private final HttpClientConnectionOperator connectionOperator;
>      private final HttpConnectionFactory<HttpRoute, ManagedHttpClientConnection> connFactory;
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/CPoolEntry.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/CPoolEntry.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/CPoolEntry.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/CPoolEntry.java Sun Jan 26 15:14:25 2014
> @@ -43,7 +43,7 @@ import org.apache.http.pool.PoolEntry;
>  @ThreadSafe
>  class CPoolEntry extends PoolEntry<HttpRoute, ManagedHttpClientConnection> {
>
> -       private final String tag = getClass().getSimpleName();
> +       private static final String tag = "CPoolEntry";
>      private volatile boolean routeComplete;
>
>      public CPoolEntry(
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/DefaultHttpResponseParser.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/DefaultHttpResponseParser.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/DefaultHttpResponseParser.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/DefaultHttpResponseParser.java Sun Jan 26 15:14:25 2014
> @@ -58,7 +58,7 @@ import org.apache.http.util.CharArrayBuf
>  @NotThreadSafe
>  public class DefaultHttpResponseParser extends AbstractMessageParserHC4<HttpResponse> {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "HttpResponseParser";
>
>      private final HttpResponseFactory responseFactory;
>      private final CharArrayBuffer lineBuf;
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/HttpClientConnectionOperator.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/HttpClientConnectionOperator.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/HttpClientConnectionOperator.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/HttpClientConnectionOperator.java Sun Jan 26 15:14:25 2014
> @@ -58,7 +58,7 @@ class HttpClientConnectionOperator {
>
>      static final String SOCKET_FACTORY_REGISTRY = "http.socket-factory-registry";
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "ConnOperator";
>
>      private final Lookup<ConnectionSocketFactory> socketFactoryRegistry;
>      private final SchemePortResolver schemePortResolver;
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/InMemoryDnsResolver.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/InMemoryDnsResolver.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/InMemoryDnsResolver.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/InMemoryDnsResolver.java Sun Jan 26 15:14:25 2014
> @@ -44,7 +44,7 @@ import org.apache.http.util.Args;
>   */
>  public class InMemoryDnsResolver implements DnsResolver {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "InMemoryDnsResolver";
>
>      /**
>       * In-memory collection that will hold the associations between a host name
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/LoggingManagedHttpClientConnection.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/LoggingManagedHttpClientConnection.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/LoggingManagedHttpClientConnection.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/LoggingManagedHttpClientConnection.java Sun Jan 26 15:14:25 2014
> @@ -47,7 +47,7 @@ import java.nio.charset.CharsetEncoder;
>  @NotThreadSafe
>  class LoggingManagedHttpClientConnection extends DefaultManagedHttpClientConnection {
>
> -       private final static String tag = ManagedHttpClientConnectionFactory.class.getName();
> +       private final static String tag = "ManagedConnection";
>         private final static String headertag = "org.apache.http.headers";
>      private final WireHC4 wire;
>
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/conn/PoolingHttpClientConnectionManager.java Sun Jan 26 15:14:25 2014
> @@ -86,7 +86,7 @@ import org.apache.http.util.Asserts;
>  public class PoolingHttpClientConnectionManager
>      implements HttpClientConnectionManager, ConnPoolControl<HttpRoute>, Closeable {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "PoolingConnManager";
>
>      private final ConfigData configData;
>      private final CPool pool;
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/ConnectionHolder.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/ConnectionHolder.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/ConnectionHolder.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/ConnectionHolder.java Sun Jan 26 15:14:25 2014
> @@ -46,7 +46,7 @@ import org.apache.http.conn.HttpClientCo
>  @ThreadSafe
>  class ConnectionHolder implements ConnectionReleaseTrigger, Cancellable, Closeable {
>
> -    private final String tag;
> +    private static final String tag = "ConnectionHolder";
>
>      private final HttpClientConnectionManager manager;
>      private final HttpClientConnection managedConn;
> @@ -58,11 +58,9 @@ class ConnectionHolder implements Connec
>      private volatile boolean released;
>
>      public ConnectionHolder(
> -            final String tag,
>              final HttpClientConnectionManager manager,
>              final HttpClientConnection managedConn) {
>          super();
> -        this.tag = tag;
>          this.manager = manager;
>          this.managedConn = managedConn;
>      }
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/MainClientExec.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/MainClientExec.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/MainClientExec.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/MainClientExec.java Sun Jan 26 15:14:25 2014
> @@ -86,7 +86,7 @@ import org.apache.http.util.EntityUtilsH
>  @Immutable
>  public class MainClientExec implements ClientExecChain {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "MainClientExec";
>
>      private final HttpRequestExecutor requestExecutor;
>      private final HttpClientConnectionManager connManager;
> @@ -194,7 +194,7 @@ public class MainClientExec implements C
>              }
>          }
>
> -        final ConnectionHolder connHolder = new ConnectionHolder(this.tag, this.connManager, managedConn);
> +        final ConnectionHolder connHolder = new ConnectionHolder(this.connManager, managedConn);
>          try {
>              if (execAware != null) {
>                  execAware.setCancellable(connHolder);
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/MinimalClientExec.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/MinimalClientExec.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/MinimalClientExec.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/MinimalClientExec.java Sun Jan 26 15:14:25 2014
> @@ -33,8 +33,6 @@ import java.net.URI;
>  import java.util.concurrent.ExecutionException;
>  import java.util.concurrent.TimeUnit;
>
> -import android.util.Log;
> -
>  import org.apache.http.ConnectionReuseStrategy;
>  import org.apache.http.HttpClientConnection;
>  import org.apache.http.HttpEntity;
> @@ -76,7 +74,7 @@ import org.apache.http.util.VersionInfoH
>  @Immutable
>  public class MinimalClientExec implements ClientExecChain {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "MinimalClientExec";
>
>      private final HttpRequestExecutor requestExecutor;
>      private final HttpClientConnectionManager connManager;
> @@ -141,7 +139,7 @@ public class MinimalClientExec implement
>              throw new RequestAbortedException("Request execution failed", cause);
>          }
>
> -        final ConnectionHolder releaseTrigger = new ConnectionHolder(getClass().getName(), connManager, managedConn);
> +        final ConnectionHolder releaseTrigger = new ConnectionHolder(connManager, managedConn);
>          try {
>              if (execAware != null) {
>                  if (execAware.isAborted()) {
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/ProtocolExec.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/ProtocolExec.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/ProtocolExec.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/ProtocolExec.java Sun Jan 26 15:14:25 2014
> @@ -71,7 +71,7 @@ import org.apache.http.util.Args;
>  @SuppressWarnings("deprecation")
>  public class ProtocolExec implements ClientExecChain {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "ProtocolExec";
>
>      private final ClientExecChain requestExecutor;
>      private final HttpProcessor httpProcessor;
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/RedirectExec.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/RedirectExec.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/RedirectExec.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/RedirectExec.java Sun Jan 26 15:14:25 2014
> @@ -67,7 +67,7 @@ import org.apache.http.util.EntityUtilsH
>  @ThreadSafe
>  public class RedirectExec implements ClientExecChain {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "RedirectExec";
>
>      private final ClientExecChain requestExecutor;
>      private final RedirectStrategy redirectStrategy;
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/RetryExec.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/RetryExec.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/RetryExec.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/RetryExec.java Sun Jan 26 15:14:25 2014
> @@ -57,7 +57,7 @@ import org.apache.http.util.Args;
>  @Immutable
>  public class RetryExec implements ClientExecChain {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "RetryExec";
>
>      private final ClientExecChain requestExecutor;
>      private final HttpRequestRetryHandler retryHandler;
>
> Modified: httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/ServiceUnavailableRetryExec.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/ServiceUnavailableRetryExec.java?rev=1561504&r1=1561503&r2=1561504&view=diff
> ==============================================================================
> --- httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/ServiceUnavailableRetryExec.java (original)
> +++ httpcomponents/httpclient-android/branches/test-branch/src/main/java/org/apache/http/impl/execchain/ServiceUnavailableRetryExec.java Sun Jan 26 15:14:25 2014
> @@ -56,7 +56,7 @@ import org.apache.http.util.Args;
>  @Immutable
>  public class ServiceUnavailableRetryExec implements ClientExecChain {
>
> -    private final String tag = getClass().getSimpleName();
> +    private static final String tag = "503RetryExec";
>
>      private final ClientExecChain requestExecutor;
>      private final ServiceUnavailableRetryStrategy retryStrategy;
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org