You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/04/12 22:19:15 UTC

[GitHub] rahul003 commented on a change in pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in CSVIter

rahul003 commented on a change in pull request #10533: [MXNET-314] [WIP] Support Integer Type parsing in CSVIter
URL: https://github.com/apache/incubator-mxnet/pull/10533#discussion_r181237709
 
 

 ##########
 File path: src/io/iter_csv.cc
 ##########
 @@ -54,27 +57,90 @@ struct CSVIterParam : public dmlc::Parameter<CSVIterParam> {
     index_t shape1[] = {1};
     DMLC_DECLARE_FIELD(label_shape).set_default(TShape(shape1, shape1 + 1))
         .describe("The shape of one label.");
+    DMLC_DECLARE_FIELD(dtype)
+      .add_enum("float32", mshadow::kFloat32)
+      .add_enum("int32", mshadow::kInt32)
+      .set_default(dmlc::optional<int>())
 
 Review comment:
   Could you default to float32?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services