You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/07/06 13:00:24 UTC

[GitHub] [flink] vchangpengfei opened a new pull request, #20185: [FLINK-28358][connector/jdbc][Tests] fix when debug in local ,the SqlValidatorImpl.class conflict problem and add lookup testcase

vchangpengfei opened a new pull request, #20185:
URL: https://github.com/apache/flink/pull/20185

   …ValidatorImpl.class conflict problem
   
   
   ## fix class conflict when run in idea
   
   *  when run test `org.apache.flink.connector.jdbc.table.JdbcLookupTableITCase.testLookup` in local idea,the jar of calcite-core.jar is loaded before  mudule of flink-table-planner ,lead to  ValidatorImpl.class in calcite-core.jar load priority*
   
   
   ## Brief change log
   
     - *change the dependency order in pom*
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as *apache.flink.connector.jdbc.table.JdbcLookupTableITCase.testLookup*.
   
   before
   <img width="416" alt="image" src="https://user-images.githubusercontent.com/37330503/176981635-0c51ece1-d382-47cb-a684-030981991748.png">
   after
   <img width="413" alt="image" src="https://user-images.githubusercontent.com/37330503/176981669-f43ad95e-b517-4fd4-9cfb-eaa6a169d5bd.png">
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: ( no )
     - The runtime per-record code paths (performance sensitive): (no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no )
     - The S3 file system connector: ( no )
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   
   because flink-table-planner use maven-shade-plugin if run with maven directly is ok，but run in idea may lead to exception 
   
   hope to help others in the community, feel free to review
   thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20185: [FLINK-28358][connector/jdbc][Tests] fix when debug in local ,the SqlValidatorImpl.class conflict problem and add lookup testcase

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20185:
URL: https://github.com/apache/flink/pull/20185#issuecomment-1176204000

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "4885eb7a4994e20dbb211ba2dff968b538803bc6",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "4885eb7a4994e20dbb211ba2dff968b538803bc6",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 4885eb7a4994e20dbb211ba2dff968b538803bc6 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser closed pull request #20185: [FLINK-28358][connector/jdbc][Tests] fix when debug in local ,the SqlValidatorImpl.class conflict problem and add lookup testcase

Posted by GitBox <gi...@apache.org>.
MartijnVisser closed pull request #20185: [FLINK-28358][connector/jdbc][Tests] fix when debug in local ,the SqlValidatorImpl.class conflict problem and add lookup testcase
URL: https://github.com/apache/flink/pull/20185


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] MartijnVisser commented on pull request #20185: [FLINK-28358][connector/jdbc][Tests] fix when debug in local ,the SqlValidatorImpl.class conflict problem and add lookup testcase

Posted by GitBox <gi...@apache.org>.
MartijnVisser commented on PR #20185:
URL: https://github.com/apache/flink/pull/20185#issuecomment-1332706878

   @vchangpengfei We've now moved the code from the JDBC connector to its own dedicated repository; please re-route this PR to https://github.com/apache/flink-connector-jdbc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org