You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/13 15:47:33 UTC

[GitHub] [shardingsphere] DivvSaxena opened a new pull request, #22155: Update Metadata

DivvSaxena opened a new pull request, #22155:
URL: https://github.com/apache/shardingsphere/pull/22155

   Fixes #21485
   
   Changes proposed in this pull request:
     -
     -
     -
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#issuecomment-1320067571

   Hi @DivvSaxena Please fix CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] DivvSaxena commented on pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#issuecomment-1324910435

   Hey @RaigorJiang!
   Modified it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] DivvSaxena commented on a diff in pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on code in PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#discussion_r1025263815


##########
agent/plugins/logging/base/src/main/java/org/apache/shardingsphere/agent/plugin/logging/base/advice/MetaDataContextsFactoryAdvice.java:
##########
@@ -25,7 +25,7 @@
 import java.lang.reflect.Method;
 
 /**
- * Schema meta data loader advice.
+ * Schema metadata loader advice.
  */
 @Slf4j
 public final class MetaDataContextsFactoryAdvice implements ClassStaticMethodAroundAdvice {

Review Comment:
   Hey @RaigorJiang  , Ok Updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] DivvSaxena commented on a diff in pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on code in PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#discussion_r1021217670


##########
agent/plugins/logging/base/src/main/java/org/apache/shardingsphere/agent/plugin/logging/base/advice/MetaDataContextsFactoryAdvice.java:
##########
@@ -25,7 +25,7 @@
 import java.lang.reflect.Method;
 
 /**
- * Schema meta data loader advice.
+ * Schema metadata loader advice.
  */
 @Slf4j
 public final class MetaDataContextsFactoryAdvice implements ClassStaticMethodAroundAdvice {

Review Comment:
   Hi @RaigorJiang  It was intially "meta data" i just changed it into "metadata".



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#issuecomment-1323731558

   > Hey @RaigorJiang ! Actually the problem is that As u told me to change the class of MetadataContextFactoryAdvice.java to MetaDataContextsFactoryAdvice.java that is causing error and i am not able to understand how to fix it. 
   
   There are two problems here:
   1. You changed the file name, but did not change the class name, which does not comply with the basic rules of Java;
   2. When we modify class name, we should also modify all references related to it. You can use the class name for global search, or use IDE's refactor function.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] DivvSaxena commented on a diff in pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on code in PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#discussion_r1025263815


##########
agent/plugins/logging/base/src/main/java/org/apache/shardingsphere/agent/plugin/logging/base/advice/MetaDataContextsFactoryAdvice.java:
##########
@@ -25,7 +25,7 @@
 import java.lang.reflect.Method;
 
 /**
- * Schema meta data loader advice.
+ * Schema metadata loader advice.
  */
 @Slf4j
 public final class MetaDataContextsFactoryAdvice implements ClassStaticMethodAroundAdvice {

Review Comment:
   Hey @RaigorJiang  , Ok Updating.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] DivvSaxena commented on pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#issuecomment-1323637349

   Hey @RaigorJiang ! Actually the problem is that As u told me to change the class of MetadataContextFactoryAdvice.java to 
    MetaDataContextsFactoryAdvice.java  that is causing error and i am not able to understand how to fix  it.
   ![image](https://user-images.githubusercontent.com/111836493/203318691-daa3a638-99a3-4e72-89c7-c0e8677cab28.png)
   ![image](https://user-images.githubusercontent.com/111836493/203319110-89cf4ad0-b7a4-46cc-82e4-f701fd64beef.png)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#discussion_r1021050689


##########
agent/plugins/logging/base/src/main/java/org/apache/shardingsphere/agent/plugin/logging/base/advice/MetaDataContextsFactoryAdvice.java:
##########
@@ -25,7 +25,7 @@
 import java.lang.reflect.Method;
 
 /**
- * Schema meta data loader advice.
+ * Schema metadata loader advice.
  */
 @Slf4j
 public final class MetaDataContextsFactoryAdvice implements ClassStaticMethodAroundAdvice {

Review Comment:
   Hi @DivvSaxena 
   Why did you change the comment but without the class name?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] DivvSaxena commented on pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#issuecomment-1319990725

   @RaigorJiang  Please review it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#issuecomment-1325095987

   > Hey @RaigorJiang! Modified it.
   
   Please execute the following command locally to ensure that the compilation passes
   `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#issuecomment-1336329476

   Hi @DivvSaxena 
   Sorry, CI is always in a failed state, so this PR cannot be merged.
   The issue requires some knowledge of Java compilation, should we ask others to help?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yx9o commented on pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
yx9o commented on PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#issuecomment-1338632812

   @RaigorJiang Hi, I want to participate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on a diff in pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on code in PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#discussion_r1021221307


##########
agent/plugins/logging/base/src/main/java/org/apache/shardingsphere/agent/plugin/logging/base/advice/MetaDataContextsFactoryAdvice.java:
##########
@@ -25,7 +25,7 @@
 import java.lang.reflect.Method;
 
 /**
- * Schema meta data loader advice.
+ * Schema metadata loader advice.
  */
 @Slf4j
 public final class MetaDataContextsFactoryAdvice implements ClassStaticMethodAroundAdvice {

Review Comment:
   Hi, I mean the class name `MetaDataContextsFactoryAdvice` should also be changed to `MetadataContextsFactoryAdvice`.   
   `MetaData` -> `Metadata`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] DivvSaxena commented on pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
DivvSaxena commented on PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#issuecomment-1337308032

   Hey @RaigorJiang ,Yes i think we should for some help


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-commenter commented on pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#issuecomment-1312776194

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22155?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#22155](https://codecov.io/gh/apache/shardingsphere/pull/22155?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (de2d325) into [master](https://codecov.io/gh/apache/shardingsphere/commit/9d94744161fe312dda595851a780b6174d69e4ec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9d94744) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #22155   +/-   ##
   =========================================
     Coverage     61.03%   61.03%           
     Complexity     2544     2544           
   =========================================
     Files          4120     4120           
     Lines         57324    57324           
     Branches       9705     9705           
   =========================================
     Hits          34985    34985           
     Misses        19389    19389           
     Partials       2950     2950           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ing/base/advice/MetaDataContextsFactoryAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/22155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9sb2dnaW5nL2Jhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L3BsdWdpbi9sb2dnaW5nL2Jhc2UvYWR2aWNlL01ldGFEYXRhQ29udGV4dHNGYWN0b3J5QWR2aWNlLmphdmE=) | `0.00% <ø> (ø)` | |
   | [...re/infra/database/metadata/DataSourceMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/22155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9kYXRhYmFzZS9tZXRhZGF0YS9EYXRhU291cmNlTWV0YURhdGEuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...ngsphere/infra/exception/MetaDataSQLException.java](https://codecov.io/gh/apache/shardingsphere/pull/22155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9leGNlcHRpb24vTWV0YURhdGFTUUxFeGNlcHRpb24uamF2YQ==) | `100.00% <ø> (ø)` | |
   | [...gsphere/infra/metadata/ShardingSphereMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/22155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9TaGFyZGluZ1NwaGVyZU1ldGFEYXRhLmphdmE=) | `80.76% <ø> (ø)` | |
   | [...nfra/metadata/database/ShardingSphereDatabase.java](https://codecov.io/gh/apache/shardingsphere/pull/22155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9TaGFyZGluZ1NwaGVyZURhdGFiYXNlLmphdmE=) | `83.33% <ø> (ø)` | |
   | [.../infra/metadata/database/schema/SchemaManager.java](https://codecov.io/gh/apache/shardingsphere/pull/22155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvU2NoZW1hTWFuYWdlci5qYXZh) | `71.42% <ø> (ø)` | |
   | [...infra/context/refresher/MetaDataRefreshEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/22155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5mcmEvY29udGV4dC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvY29udGV4dC9yZWZyZXNoZXIvTWV0YURhdGFSZWZyZXNoRW5naW5lLmphdmE=) | `100.00% <ø> (ø)` | |
   | [...shardingsphere/mode/metadata/MetaDataContexts.java](https://codecov.io/gh/apache/shardingsphere/pull/22155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL01ldGFEYXRhQ29udGV4dHMuamF2YQ==) | `87.50% <ø> (ø)` | |
   | [...gsphere/mode/metadata/MetaDataContextsFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/22155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL01ldGFEYXRhQ29udGV4dHNGYWN0b3J5LmphdmE=) | `79.48% <ø> (ø)` | |
   | [.../mode/metadata/persist/MetaDataPersistService.java](https://codecov.io/gh/apache/shardingsphere/pull/22155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bW9kZS9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9tb2RlL21ldGFkYXRhL3BlcnNpc3QvTWV0YURhdGFQZXJzaXN0U2VydmljZS5qYXZh) | `65.90% <ø> (ø)` | |
   | ... and [2 more](https://codecov.io/gh/apache/shardingsphere/pull/22155/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang commented on pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
RaigorJiang commented on PR #22155:
URL: https://github.com/apache/shardingsphere/pull/22155#issuecomment-1340258012

   @DivvSaxena, @yx9o Thank you,  so I just close this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] RaigorJiang closed pull request #22155: Update Metadata

Posted by GitBox <gi...@apache.org>.
RaigorJiang closed pull request #22155: Update Metadata
URL: https://github.com/apache/shardingsphere/pull/22155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org