You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by "Qiang Zhang (JIRA)" <ji...@apache.org> on 2018/04/02 07:15:00 UTC
[jira] [Commented] (RANGER-2054) Fix new findBugs in
RangerAdminClientImpl.java for kylin plugin test
[ https://issues.apache.org/jira/browse/RANGER-2054?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421989#comment-16421989 ]
Qiang Zhang commented on RANGER-2054:
-------------------------------------
Review Requet:
https://reviews.apache.org/r/66389/
Solution patch, please see attachment:
[patch|https://issues.apache.org/jira/secure/attachment/12917167/0001-RANGER-2054-Fix-new-findBugs-in-RangerAdminClientImp.patch]
> Fix new findBugs in RangerAdminClientImpl.java for kylin plugin test
> --------------------------------------------------------------------
>
> Key: RANGER-2054
> URL: https://issues.apache.org/jira/browse/RANGER-2054
> Project: Ranger
> Issue Type: Bug
> Components: plugins
> Affects Versions: 1.1.0
> Reporter: Qiang Zhang
> Assignee: Qiang Zhang
> Priority: Minor
> Labels: patch
> Fix For: 1.1.0
>
> Attachments: 0001-RANGER-2054-Fix-new-findBugs-in-RangerAdminClientImp.patch
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> ________________________________________________________________________________________________________
> *** CID 175091: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING)
> /plugin-kylin/src/test/java/org/apache/ranger/authorization/kylin/authorizer/RangerAdminClientImpl.java: 68 in org.apache.ranger.authorization.kylin.authorizer.RangerAdminClientImpl.getServicePoliciesIfUpdated(long, long)()
> 62 }
> 63
> 64 java.nio.file.Path cachePath = FileSystems.getDefault()
> 65 .getPath(basedir, "/src/test/resources/" + cacheFilename);
> 66 byte[] cacheBytes = Files.readAllBytes(cachePath);
> 67
> >>> CID 175091: FindBugs: Internationalization (FB.DM_DEFAULT_ENCODING)
> >>> Found reliance on default encoding: new String(byte[]).
> 68 return gson.fromJson(new String(cacheBytes), ServicePolicies.class);
> 69 }
> 70
> 71 @Override
> 72 public void grantAccess(GrantRevokeRequest request) throws Exception {
> 73
> To view the defects in Coverity Scan visit, https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZSbhom32dlDl11LWEm9nX11zsOWMf5dv3Q9Mogo-2FGua3FsLRTFft2V-2FOFC9o0P2e0-3D_d04ZgyDzSjlwpjXIuOFYDNE6R93Lal83MDClQK32PZsnIXFWgRi957MYBuy-2FlDkytlroFFT4DodK8yWwhtaHLaX8VDTgQexZ1KpM2ghdONIK2s05PzHFJPHt35agqZ9nM-2FaTS-2BwGKR0yiHd9VqwUDlZAGDFlrUyAnUh6f6i-2B3anlkbZqOzVnGOBWkfRi-2BewYxNrjphgpV2suFoBTWVzO0g-3D-3D
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)