You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "James Miller (Created) (JIRA)" <ji...@apache.org> on 2011/12/22 15:31:31 UTC

[jira] [Created] (HTTPCLIENT-1155) CachingHttpClient should have similar behavior as AbstractHttpClient when executing with ResponseHandler

CachingHttpClient should have similar behavior as AbstractHttpClient when executing with ResponseHandler
--------------------------------------------------------------------------------------------------------

                 Key: HTTPCLIENT-1155
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1155
             Project: HttpComponents HttpClient
          Issue Type: Bug
          Components: Cache
    Affects Versions: 4.1.2, 4.2 Alpha2
            Reporter: James Miller


When calling execute on the AbstractHttpClient with a  ResponseHandler, the AbstractHttpClient will attempt to Consume the Entity and close any open connections before returning. This behavior is not currently in the CachingHttpClient. 

This can lead to connection leaks when switching to CachingHttpClient, becuase the responsibility to fully consume the entity is now on the ResponseHandler instead on the HttpClient.

Here is the code that does the existing 'auto-close' behavior: "org.apache.http.impl.client.AbstractHttpClient.java" lines 1080-1111

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Resolved] (HTTPCLIENT-1155) CachingHttpClient should have similar behavior as AbstractHttpClient when executing with ResponseHandler

Posted by "Oleg Kalnichevski (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Oleg Kalnichevski resolved HTTPCLIENT-1155.
-------------------------------------------

       Resolution: Fixed
    Fix Version/s: 4.2 Alpha2
                   4.1.3

Patch committed to SVN trunk and 4.1.x branch. Many thanks for contributing it, James

Oleg
                
> CachingHttpClient should have similar behavior as AbstractHttpClient when executing with ResponseHandler
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1155
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1155
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.1.2, 4.2 Alpha2
>            Reporter: James Miller
>              Labels: cache, leak
>             Fix For: 4.1.3, 4.2 Alpha2
>
>         Attachments: httpclient-1155.patch
>
>
> When calling execute on the AbstractHttpClient with a  ResponseHandler, the AbstractHttpClient will attempt to Consume the Entity and close any open connections before returning. This behavior is not currently in the CachingHttpClient. 
> This can lead to connection leaks when switching to CachingHttpClient, becuase the responsibility to fully consume the entity is now on the ResponseHandler instead on the HttpClient.
> Here is the code that does the existing 'auto-close' behavior: "org.apache.http.impl.client.AbstractHttpClient.java" lines 1080-1111

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[jira] [Updated] (HTTPCLIENT-1155) CachingHttpClient should have similar behavior as AbstractHttpClient when executing with ResponseHandler

Posted by "James Miller (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Miller updated HTTPCLIENT-1155:
-------------------------------------

    Attachment: httpclient-1155.patch

Patch to add 'auto-consume' to cachinghttpclient
                
> CachingHttpClient should have similar behavior as AbstractHttpClient when executing with ResponseHandler
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1155
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1155
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.1.2, 4.2 Alpha2
>            Reporter: James Miller
>              Labels: cache, leak
>         Attachments: httpclient-1155.patch
>
>
> When calling execute on the AbstractHttpClient with a  ResponseHandler, the AbstractHttpClient will attempt to Consume the Entity and close any open connections before returning. This behavior is not currently in the CachingHttpClient. 
> This can lead to connection leaks when switching to CachingHttpClient, becuase the responsibility to fully consume the entity is now on the ResponseHandler instead on the HttpClient.
> Here is the code that does the existing 'auto-close' behavior: "org.apache.http.impl.client.AbstractHttpClient.java" lines 1080-1111

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org