You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/09/13 13:48:17 UTC
[GitHub] [dolphinscheduler] 106umao commented on a diff in pull request #11670: [Feature-11473][Task]Support test task
106umao commented on code in PR #11670:
URL: https://github.com/apache/dolphinscheduler/pull/11670#discussion_r969651308
##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_postgresql.sql:
##########
@@ -287,6 +288,8 @@ CREATE TABLE t_ds_datasource (
connection_params text NOT NULL ,
create_time timestamp NOT NULL ,
update_time timestamp DEFAULT NULL ,
+ test_flag int DEFAULT NULL ,
Review Comment:
You should use tinyint (4) as above
##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_postgresql.sql:
##########
@@ -268,6 +268,7 @@ CREATE TABLE t_ds_command (
dry_run int DEFAULT '0' ,
process_instance_id int DEFAULT 0,
process_definition_version int DEFAULT 0,
+ test_flag int DEFAULT NULL ,
Review Comment:
You should use tinyint (4) as above
##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_postgresql.sql:
##########
@@ -773,6 +777,7 @@ CREATE TABLE t_ds_task_instance (
dry_run int DEFAULT '0' ,
cpu_quota int DEFAULT '-1' NOT NULL,
memory_max int DEFAULT '-1' NOT NULL,
+ test_flag int DEFAULT NULL ,
Review Comment:
You should use tinyint (4) as above
##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_h2.sql:
##########
@@ -392,6 +395,7 @@ CREATE TABLE t_ds_error_command
dry_run int NULL DEFAULT 0,
process_instance_id int(11) DEFAULT 0,
process_definition_version int(11) DEFAULT 0,
+ test_flag int NULL DEFAULT 0,
Review Comment:
You should use tinyint (4)
##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_h2.sql:
##########
@@ -873,6 +878,7 @@ CREATE TABLE t_ds_task_instance
dry_run int NULL DEFAULT 0,
cpu_quota int(11) DEFAULT '-1' NOT NULL,
memory_max int(11) DEFAULT '-1' NOT NULL,
+ test_flag int NULL DEFAULT 0,
Review Comment:
You should use tinyint (4)
##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_h2.sql:
##########
@@ -620,6 +624,7 @@ CREATE TABLE t_ds_process_instance
var_pool longtext,
dry_run int NULL DEFAULT 0,
restart_time datetime DEFAULT NULL,
+ test_flag int NULL DEFAULT 0,
Review Comment:
You should use tinyint (4)
##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_h2.sql:
##########
@@ -359,6 +360,8 @@ CREATE TABLE t_ds_datasource
connection_params text NOT NULL,
create_time datetime NOT NULL,
update_time datetime DEFAULT NULL,
+ test_flag int DEFAULT NULL,
Review Comment:
You should use tinyint (4)
##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_postgresql.sql:
##########
@@ -550,6 +553,7 @@ CREATE TABLE t_ds_process_instance (
dry_run int DEFAULT '0' ,
next_process_instance_id int DEFAULT '0',
restart_time timestamp DEFAULT NULL ,
+ test_flag int DEFAULT NULL ,
Review Comment:
You should use tinyint (4) as above
##########
dolphinscheduler-dao/src/main/resources/sql/dolphinscheduler_h2.sql:
##########
@@ -337,6 +337,7 @@ CREATE TABLE t_ds_command
dry_run int NULL DEFAULT 0,
process_instance_id int(11) DEFAULT 0,
process_definition_version int(11) DEFAULT 0,
+ test_flag int NULL DEFAULT 0,
Review Comment:
You should use tinyint (4)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org