You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/04/30 23:23:00 UTC

[jira] [Updated] (GEODE-9230) Remove magic numbers in GfshParserAutoCompletionIntegrationTest

     [ https://issues.apache.org/jira/browse/GEODE-9230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ASF GitHub Bot updated GEODE-9230:
----------------------------------
    Labels: pull-request-available  (was: )

> Remove magic numbers in GfshParserAutoCompletionIntegrationTest
> ---------------------------------------------------------------
>
>                 Key: GEODE-9230
>                 URL: https://issues.apache.org/jira/browse/GEODE-9230
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Alberto Bustamante Reyes
>            Assignee: Alberto Bustamante Reyes
>            Priority: Major
>              Labels: pull-request-available
>
> GfshParserAutoCompletionIntegrationTest uses magic numbers in some tests. They depend on the number of possible parameters of "start server" command.
> That means that when a new parameter is added to the "start server" command, some tests verifying the gfsh autocompletion feature are impacted, which has no sense.
> The number of parameters can be calculated instead of hardcoded in order to remove this dependency.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)