You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2019/10/14 20:39:01 UTC

[GitHub] [lucene-solr] ctargett opened a new pull request #952: SOLR-12786: update Ref Guide build tooling versions

ctargett opened a new pull request #952: SOLR-12786: update Ref Guide build tooling versions
URL: https://github.com/apache/lucene-solr/pull/952
 
 
   # Description
   Upgrading tool versions was held back by needing to fix several headings since Asciidoctor changed the way they construct automatic section ids in the 1.5.7 release. Other tooling had also fallen behind.
   
   # Solution
   
   - Updated asciidoctor-ant version to 1.6.2 for the PDF build.
   - Updated `solr-ref-guide/README.adoc` to reflect latest versions of the tools.
   -- Since Asciidoctor 2.0.10 is installed by default with jekyll-asciidoc, removed the requirement to install Asciidoctor separately.
   -- jekyll-asciidoc version updated to 3.0.0.
   -- dependencies to install slim, tilt, and concurrent-ruby (replaced thread_safe) added.
   - Removed pygments.rb as a dependency and replaced it with the rouge highlighter which comes with Jekyll out of the box.
   - Fixed several pages which failed validation after updating the asciidoctor version.
   - Updated the Jenkins build script with new supported versions. To prevent nasty surprises in the future, I kept the gem installs to force installation of specific versions, but updated those versions to the latest.
   
   Since there are significant changes in Jekyll 4.x, I did not at this time upgrade that part of the HTML build tooling so v3.5.0 is still required (possible we could go to 3.8.x but I didn't look at that either).
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
   - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [x] I have developed this patch against the `master` branch.
   - [x] I have run `ant precommit` and the appropriate test suite.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org