You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by "okumin (via GitHub)" <gi...@apache.org> on 2023/05/27 02:07:57 UTC
[GitHub] [hive] okumin opened a new pull request, #4363: HIVE-24606: Multi-stage materialized CTEs can lose intermediate data
okumin opened a new pull request, #4363:
URL: https://github.com/apache/hive/pull/4363
### What changes were proposed in this pull request?
Build correct dependencies among CTEs in order to prevent wrong results.
### Why are the changes needed?
A Hive query with `hive.optimize.cte.materialize.threshold` can return wrong results when it has complex CTEs.
The issue can happen when multistage CTEs have dependencies and SemanticAnalyzer fails to link their tasks.
https://issues.apache.org/jira/browse/HIVE-24606
### Does this PR introduce _any_ user-facing change?
Incorrect results will be correct results.
### How was this patch tested?
This PR adds three test cases. All fail when we use the latest revision(`7bfc54ffc8baf5f3e7de326b750fe9355b11132b`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4363: HIVE-24606: Multi-stage materialized CTEs can lose intermediate data
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4363:
URL: https://github.com/apache/hive/pull/4363#issuecomment-1720614227
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4363)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4363&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4363&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4363&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4363&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4363&metric=duplicated_lines_density&view=list) No Duplication information
 The version of Java (11.0.8) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] okumin commented on a diff in pull request #4363: HIVE-24606: Multi-stage materialized CTEs can lose intermediate data
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on code in PR #4363:
URL: https://github.com/apache/hive/pull/4363#discussion_r1326727402
##########
ql/src/test/queries/clientpositive/cte_mat_10.q:
##########
@@ -0,0 +1,23 @@
+set hive.optimize.cte.materialize.threshold=2;
+set hive.optimize.cte.materialize.full.aggregate.only=false;
+set hive.explain.user=true;
Review Comment:
I can no longer find the reason since this case was written 3 years ago. Anyway, I removed it and reran all test cases.
- [Stopped setting hive.explain.user, added EXPLAIN, and reran 3 test cases](https://github.com/apache/hive/pull/4363/commits/368f66e5425524aa3fbd0b32b37227ecab558d73)
- [Merged master because I found some of new test cases are affected by other PRs](https://github.com/apache/hive/pull/4363/commits/3a37c9729f8728c32bc33fce18b7c66dddc56ff3)
- [Reran the tests again](https://github.com/apache/hive/pull/4363/commits/de051af22caebb7e533927371ac39d111a130921)
I am waiting for CI to finish
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz commented on a diff in pull request #4363: HIVE-24606: Multi-stage materialized CTEs can lose intermediate data
Posted by "kasakrisz (via GitHub)" <gi...@apache.org>.
kasakrisz commented on code in PR #4363:
URL: https://github.com/apache/hive/pull/4363#discussion_r1324479188
##########
ql/src/test/queries/clientpositive/cte_mat_10.q:
##########
@@ -0,0 +1,23 @@
+set hive.optimize.cte.materialize.threshold=2;
+set hive.optimize.cte.materialize.full.aggregate.only=false;
+set hive.explain.user=true;
+
+with x as ( select 'x' as id ),
Review Comment:
Could you please add an explain statement in order to print the plan
##########
ql/src/test/queries/clientpositive/cte_mat_10.q:
##########
@@ -0,0 +1,23 @@
+set hive.optimize.cte.materialize.threshold=2;
+set hive.optimize.cte.materialize.full.aggregate.only=false;
+set hive.explain.user=true;
Review Comment:
Why did user.explain set to true? The plan has more details when it is false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kasakrisz merged pull request #4363: HIVE-24606: Multi-stage materialized CTEs can lose intermediate data
Posted by "kasakrisz (via GitHub)" <gi...@apache.org>.
kasakrisz merged PR #4363:
URL: https://github.com/apache/hive/pull/4363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] closed pull request #4363: HIVE-24606: Multi-stage materialized CTEs can lose intermediate data
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #4363: HIVE-24606: Multi-stage materialized CTEs can lose intermediate data
URL: https://github.com/apache/hive/pull/4363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] aturoczy commented on pull request #4363: HIVE-24606: Multi-stage materialized CTEs can lose intermediate data
Posted by "aturoczy (via GitHub)" <gi...@apache.org>.
aturoczy commented on PR #4363:
URL: https://github.com/apache/hive/pull/4363#issuecomment-1573309453
@kasakrisz @zabetak Could you pls check this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] okumin commented on a diff in pull request #4363: HIVE-24606: Multi-stage materialized CTEs can lose intermediate data
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on code in PR #4363:
URL: https://github.com/apache/hive/pull/4363#discussion_r1207584190
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -1440,47 +1443,78 @@ public String toString() {
}
}
- private List<Task<?>> toRealRootTasks(List<CTEClause> execution) {
- List<Task<?>> cteRoots = new ArrayList<>();
- List<Task<?>> cteLeafs = new ArrayList<>();
- List<Task<?>> curTopRoots = null;
Review Comment:
This looks like the root cause. In [the case I put in the ticket](https://issues.apache.org/jira/browse/HIVE-24606), there are the following dependencies.
- `<root> -> a1`
- `<root> -> x`
- `<root> -> a2`
- `a2 -> a1`
But the old implementation tries to traverse CTEs in order of `a1` -> `x` -> `a2` -> `<root>`, following the appearance in the AST.
As a result, when it visits `a2`, the information of `a1` has gone and it fails to link `a2` with `a1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] okumin commented on a diff in pull request #4363: HIVE-24606: Multi-stage materialized CTEs can lose intermediate data
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on code in PR #4363:
URL: https://github.com/apache/hive/pull/4363#discussion_r1207584190
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java:
##########
@@ -1440,47 +1443,78 @@ public String toString() {
}
}
- private List<Task<?>> toRealRootTasks(List<CTEClause> execution) {
- List<Task<?>> cteRoots = new ArrayList<>();
- List<Task<?>> cteLeafs = new ArrayList<>();
- List<Task<?>> curTopRoots = null;
Review Comment:
This looks like the root cause. In [the case I put in the ticket](https://issues.apache.org/jira/browse/HIVE-24606), there are the following dependencies.
- `<root> -> a1`
- `<root> -> x`
- `<root> -> a2`
- `a2 -> a1`
But the old implementation tries to traverse CTEs in order of `a1` -> `x` -> `a2` -> `<root>`, following the appearance of AST.
As a result, when it visits `a2`, the information of `a1` has gone and it fails to link `a2` with `a1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4363: HIVE-24606: Multi-stage materialized CTEs can lose intermediate data
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4363:
URL: https://github.com/apache/hive/pull/4363#issuecomment-1565180915
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4363)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4363&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4363&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4363&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4363&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4363&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] okumin commented on pull request #4363: HIVE-24606: Multi-stage materialized CTEs can lose intermediate data
Posted by "okumin (via GitHub)" <gi...@apache.org>.
okumin commented on PR #4363:
URL: https://github.com/apache/hive/pull/4363#issuecomment-1722108429
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] sonarcloud[bot] commented on pull request #4363: HIVE-24606: Multi-stage materialized CTEs can lose intermediate data
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #4363:
URL: https://github.com/apache/hive/pull/4363#issuecomment-1718147110
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_hive&pullRequest=4363)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4363&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4363&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_hive&pullRequest=4363&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=CODE_SMELL) [12 Code Smells](https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=4363&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4363&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_hive&pullRequest=4363&metric=duplicated_lines_density&view=list) No Duplication information
 The version of Java (11.0.8) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more [here](https://docs.sonarcloud.io/appendices/scanner-environment/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] github-actions[bot] commented on pull request #4363: HIVE-24606: Multi-stage materialized CTEs can lose intermediate data
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #4363:
URL: https://github.com/apache/hive/pull/4363#issuecomment-1661277328
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Feel free to reach out on the dev@hive.apache.org list if the patch is in need of reviews.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org