You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/07/26 14:40:21 UTC
[GitHub] [incubator-pekko-connectors-kafka] mdedetrich opened a new pull request, #117: Add sbt-license-report
mdedetrich opened a new pull request, #117:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/117
Adds license report
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on pull request #117: Add sbt-license-report
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #117:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/117#issuecomment-1660748738
> @pjfanning So the vote for this project passed, what are your thoughts on this?
* The new 1.0.0 jars should be built off the commit that was voted on so merging this does not affect that.
* We don't yet have 1.0.0 docs published. We could choose to build those from the same commit as we voted on or we could build them based on latest commits (including this). I think it isn't a big deal if the license report is slightly incorrect (rs-api jar has been upgraded since the vote was called).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] mdedetrich commented on pull request #117: Add sbt-license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #117:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/117#issuecomment-1660755681
> > @pjfanning So the vote for this project passed, what are your thoughts on this?
>
> * The new 1.0.0 jars should be built off the commit that was voted on so merging this does not affect that.
> * We don't yet have 1.0.0 docs published. We could choose to build those from the same commit as we voted on or we could build them based on latest commits (including this). I think it isn't a big deal if the license report is slightly incorrect (rs-api jar has been upgraded since the vote was called).
Okay, I will build off the 1.0.0-RC1 commit and we can merge this for the docs, as you said I don't think a test dependency being slightly incorrect is a big deal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] mdedetrich commented on pull request #117: Add sbt-license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #117:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/117#issuecomment-1652615551
> We have 3 choices about the 1.0.0 docs for pekko-connectors-kafka:
>
> 1. merge this and generate the 1.0.0 docs with this change - which will have a slightly incorrect report about rs-api jar
> 2. merge this but set up the 1.0 doc publish job to use the git ref with the 1.0.0 git tag when generating the 1.0.0 docs
> 3. delay merging this until after we generate the 1.0.0 docs
Well I would say that we have 2 choices, choice 3 doesn't give us buy as anything (as you said we can always just make sure the job uses git ref when publishing docs, this is a non issue). If https://github.com/apache/incubator-pekko-connectors-kafka/pull/116 wasn't merged then there might have a slight case of not merging this PR, but alas thats not the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on pull request #117: Add sbt-license-report
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #117:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/117#issuecomment-1652587709
We have 3 choices about the 1.0.0 docs for pekko-connectors-kafka:
1. merge this and generate the 1.0.0 docs with this change - which will have a slightly incorrect report about rs-api jar
2. merge this but set up the 1.0 doc publish job to use the git ref with the 1.0.0 git tag when generating the 1.0.0 docs
3. delay merging this until after we generate the 1.0.0 docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] mdedetrich commented on pull request #117: Add sbt-license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #117:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/117#issuecomment-1652621875
Ill leave this open for now incase we do get some issues using a git ref (not expecting any problems here), no hurry to merge either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] mdedetrich commented on pull request #117: Add sbt-license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #117:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/117#issuecomment-1660575865
@pjfanning So the vote for this project passed, what are your thoughts on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] pjfanning commented on pull request #117: Add sbt-license-report
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #117:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/117#issuecomment-1652623833
The incubator-pekko 1.0 publish job uses a git ref in its checkout and it works fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-connectors-kafka] mdedetrich merged pull request #117: Add sbt-license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #117:
URL: https://github.com/apache/incubator-pekko-connectors-kafka/pull/117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org