You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/02/16 13:59:43 UTC
[GitHub] [maven] oopexpert opened a new pull request #326: extract methods,
apply SLA
oopexpert opened a new pull request #326: extract methods, apply SLA
URL: https://github.com/apache/maven/pull/326
Apply "extract method" refactoring to make methods smaller. Considering principle "single level of abstraction".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] oopexpert commented on issue #326: [MNG-6867] extract
methods, apply SLA DefaultMavenPluginManager
Posted by GitBox <gi...@apache.org>.
oopexpert commented on issue #326: [MNG-6867] extract methods, apply SLA DefaultMavenPluginManager
URL: https://github.com/apache/maven/pull/326#issuecomment-596712246
>
>
> Can you please rebase to most recent master and squash your commits to a single one...you can force push on that branch ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] oopexpert closed pull request #326: [MNG-6867] extract
methods, apply SLA DefaultMavenPluginManager
Posted by GitBox <gi...@apache.org>.
oopexpert closed pull request #326: [MNG-6867] extract methods, apply SLA DefaultMavenPluginManager
URL: https://github.com/apache/maven/pull/326
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] oopexpert commented on issue #326: [Refactoring] extract
methods, apply SLA
Posted by GitBox <gi...@apache.org>.
oopexpert commented on issue #326: [Refactoring] extract methods, apply SLA
URL: https://github.com/apache/maven/pull/326#issuecomment-586727285
adapted.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] michael-o commented on issue #326: [Refactoring] extract
methods, apply SLA
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #326: [Refactoring] extract methods, apply SLA
URL: https://github.com/apache/maven/pull/326#issuecomment-586719822
Please stick to the Maven code formatting convention.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] oopexpert commented on issue #326: [MNG-6867] extract
methods, apply SLA DefaultMavenPluginManager
Posted by GitBox <gi...@apache.org>.
oopexpert commented on issue #326: [MNG-6867] extract methods, apply SLA DefaultMavenPluginManager
URL: https://github.com/apache/maven/pull/326#issuecomment-596713338
>
>
> Can you please rebase to most recent master and squash your commits to a single one...you can force push on that branch ...
... which is?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] khmarbaise commented on issue #326: [MNG-6867] extract
methods, apply SLA DefaultMavenPluginManager
Posted by GitBox <gi...@apache.org>.
khmarbaise commented on issue #326: [MNG-6867] extract methods, apply SLA DefaultMavenPluginManager
URL: https://github.com/apache/maven/pull/326#issuecomment-596691192
Can you please rebase to most recent master and squash your commits to a single one...you can force push on that branch ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] oopexpert commented on issue #326: [MNG-6867] extract
methods, apply SLA DefaultMavenPluginManager
Posted by GitBox <gi...@apache.org>.
oopexpert commented on issue #326: [MNG-6867] extract methods, apply SLA DefaultMavenPluginManager
URL: https://github.com/apache/maven/pull/326#issuecomment-596722904
I squashed and rebased...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven] oopexpert opened a new pull request #326: [MNG-6867]
extract methods, apply SLA DefaultMavenPluginManager
Posted by GitBox <gi...@apache.org>.
oopexpert opened a new pull request #326: [MNG-6867] extract methods, apply SLA DefaultMavenPluginManager
URL: https://github.com/apache/maven/pull/326
Apply "extract method" refactoring to make methods smaller. Considering principle "single level of abstraction".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services