You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by gg...@apache.org on 2015/06/27 09:33:22 UTC
logging-log4j2 git commit: String.format(String,
Object[]) called with format string "}%n" wants 0 arguments but is
given 1.
Repository: logging-log4j2
Updated Branches:
refs/heads/master 14414fbfd -> a7e04f804
String.format(String, Object[]) called with format string "}%n" wants 0
arguments but is given 1.
Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/a7e04f80
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/a7e04f80
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/a7e04f80
Branch: refs/heads/master
Commit: a7e04f80455cd495b408e826a025d5978708cb8f
Parents: 14414fb
Author: ggregory <gg...@apache.org>
Authored: Sat Jun 27 00:33:20 2015 -0700
Committer: ggregory <gg...@apache.org>
Committed: Sat Jun 27 00:33:20 2015 -0700
----------------------------------------------------------------------
.../main/java/org/apache/logging/log4j/core/tools/Generate.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/a7e04f80/log4j-core/src/main/java/org/apache/logging/log4j/core/tools/Generate.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/tools/Generate.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/tools/Generate.java
index e68ffae..4aaf7f6 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/tools/Generate.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/tools/Generate.java
@@ -520,7 +520,7 @@ public final class Generate {
sb.append(String.format(phase2, ""));
}
- sb.append(String.format("}%n", ""));
+ sb.append("}%n");
return sb.toString();
}
Re: logging-log4j2 git commit: String.format(String, Object[]) called with format string "}%n" wants 0 arguments but is given 1.
Posted by Remko Popma <re...@gmail.com>.
I think this change introduced a bug: without calling String.format(), %n won't be translated to the current platform's line break char sequence...
Sent from my iPhone
> On 2015/06/27, at 16:33, ggregory@apache.org wrote:
>
> Repository: logging-log4j2
> Updated Branches:
> refs/heads/master 14414fbfd -> a7e04f804
>
>
> String.format(String, Object[]) called with format string "}%n" wants 0
> arguments but is given 1.
>
> Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
> Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/a7e04f80
> Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/a7e04f80
> Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/a7e04f80
>
> Branch: refs/heads/master
> Commit: a7e04f80455cd495b408e826a025d5978708cb8f
> Parents: 14414fb
> Author: ggregory <gg...@apache.org>
> Authored: Sat Jun 27 00:33:20 2015 -0700
> Committer: ggregory <gg...@apache.org>
> Committed: Sat Jun 27 00:33:20 2015 -0700
>
> ----------------------------------------------------------------------
> .../main/java/org/apache/logging/log4j/core/tools/Generate.java | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/a7e04f80/log4j-core/src/main/java/org/apache/logging/log4j/core/tools/Generate.java
> ----------------------------------------------------------------------
> diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/tools/Generate.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/tools/Generate.java
> index e68ffae..4aaf7f6 100644
> --- a/log4j-core/src/main/java/org/apache/logging/log4j/core/tools/Generate.java
> +++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/tools/Generate.java
> @@ -520,7 +520,7 @@ public final class Generate {
> sb.append(String.format(phase2, ""));
> }
>
> - sb.append(String.format("}%n", ""));
> + sb.append("}%n");
> return sb.toString();
> }
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org