You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "mukesh154 (via GitHub)" <gi...@apache.org> on 2024/05/31 05:44:29 UTC
[PR] [fix][io] Upgrade Debezium oracle connector version to 2.5.4.Final [pulsar]
mukesh154 opened a new pull request, #22813:
URL: https://github.com/apache/pulsar/pull/22813
### Motivation
To Upgrade debezium version for oracle to 2.5.4.Final
### Modifications
debezium 1.9.7.Final -> 2.5.4.Final
### Verifying this change
- [X] Make sure that the change passes the CI checks.
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
- [ ] `doc-required`
(If you need help on updating docs, create a doc issue)
- [X] `no-need-doc`
(Please explain why)
- [ ] `doc`
(If this PR contains doc changes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][io] Upgrade Debezium oracle connector version to 2.5.4.Final [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #22813:
URL: https://github.com/apache/pulsar/pull/22813#discussion_r1634194181
##########
pulsar-io/debezium/oracle/pom.xml:
##########
@@ -39,16 +39,49 @@
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>io.debezium</groupId>
+ <artifactId>debezium-connector-oracle</artifactId>
+ <version>${debezium.oracle.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>io.debezium</groupId>
+ <artifactId>debezium-core</artifactId>
+ <version>${debezium.oracle.version}</version>
+ </dependency>
Review Comment:
I don't think it's a great idea to have a separate version of debezium-core when Oracle connector is used. This will cause class version conflicts as we have seen before. Please see #22668 as an example of this.
I think that should be upgrading Debezium in all connectors at the same time to avoid class version conflicts and the confusion caused for maintenance when multiple versions of Debezium are used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][io] Upgrade Debezium oracle connector version to 2.5.4.Final [pulsar]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22813:
URL: https://github.com/apache/pulsar/pull/22813#issuecomment-2141272510
@mukesh154 Please add the following content to your PR description and select a checkbox:
```
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][io] Upgrade Debezium oracle connector version to 2.5.4.Final [pulsar]
Posted by "mukesh154 (via GitHub)" <gi...@apache.org>.
mukesh154 closed pull request #22813: [fix][io] Upgrade Debezium oracle connector version to 2.5.4.Final
URL: https://github.com/apache/pulsar/pull/22813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][io] Upgrade Debezium oracle connector version to 2.5.4.Final [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #22813:
URL: https://github.com/apache/pulsar/pull/22813#issuecomment-2154344602
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/22813?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `0%` with `212 lines` in your changes missing coverage. Please review.
> Project coverage is 73.17%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`2ecf604`)](https://app.codecov.io/gh/apache/pulsar/commit/2ecf6044465b65afff869a8ab7075c556e983724?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 355 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/22813?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #22813 +/- ##
============================================
- Coverage 73.57% 73.17% -0.41%
- Complexity 32624 32960 +336
============================================
Files 1877 1892 +15
Lines 139502 141902 +2400
Branches 15299 15569 +270
============================================
+ Hits 102638 103830 +1192
- Misses 28908 30054 +1146
- Partials 7956 8018 +62
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/22813/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/22813/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.41% <ø> (+2.82%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/22813/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `24.73% <0.00%> (+0.40%)` | :arrow_up: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/22813/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `72.31% <ø> (-0.54%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files](https://app.codecov.io/gh/apache/pulsar/pull/22813?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ulsar/io/debezium/oracle/DebeziumOracleSource.java](https://app.codecov.io/gh/apache/pulsar/pull/22813?src=pr&el=tree&filepath=pulsar-io%2Fdebezium%2Foracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fio%2Fdebezium%2Foracle%2FDebeziumOracleSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWlvL2RlYmV6aXVtL29yYWNsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2lvL2RlYmV6aXVtL29yYWNsZS9EZWJleml1bU9yYWNsZVNvdXJjZS5qYXZh) | `0.00% <ø> (ø)` | |
| [...g/apache/pulsar/io/debezium/oracle/SerDeUtils.java](https://app.codecov.io/gh/apache/pulsar/pull/22813?src=pr&el=tree&filepath=pulsar-io%2Fdebezium%2Foracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fio%2Fdebezium%2Foracle%2FSerDeUtils.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWlvL2RlYmV6aXVtL29yYWNsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2lvL2RlYmV6aXVtL29yYWNsZS9TZXJEZVV0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ache/pulsar/io/debezium/oracle/DebeziumSource.java](https://app.codecov.io/gh/apache/pulsar/pull/22813?src=pr&el=tree&filepath=pulsar-io%2Fdebezium%2Foracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fio%2Fdebezium%2Foracle%2FDebeziumSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWlvL2RlYmV6aXVtL29yYWNsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2lvL2RlYmV6aXVtL29yYWNsZS9EZWJleml1bVNvdXJjZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...lsar/io/debezium/oracle/PulsarDatabaseHistory.java](https://app.codecov.io/gh/apache/pulsar/pull/22813?src=pr&el=tree&filepath=pulsar-io%2Fdebezium%2Foracle%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fio%2Fdebezium%2Foracle%2FPulsarDatabaseHistory.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWlvL2RlYmV6aXVtL29yYWNsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2lvL2RlYmV6aXVtL29yYWNsZS9QdWxzYXJEYXRhYmFzZUhpc3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
... and [384 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/22813/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][io] Upgrade Debezium oracle connector version to 2.5.4.Final [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on code in PR #22813:
URL: https://github.com/apache/pulsar/pull/22813#discussion_r1634194181
##########
pulsar-io/debezium/oracle/pom.xml:
##########
@@ -39,16 +39,49 @@
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>io.debezium</groupId>
+ <artifactId>debezium-connector-oracle</artifactId>
+ <version>${debezium.oracle.version}</version>
+ </dependency>
+
+ <dependency>
+ <groupId>io.debezium</groupId>
+ <artifactId>debezium-core</artifactId>
+ <version>${debezium.oracle.version}</version>
+ </dependency>
Review Comment:
I don't think it's a great idea to have a separate version of debezium-core when Oracle connector is used. This will cause class version conflicts as we have seen before. Please see #22668 as an example of this.
I think that should be upgrading Debezium in all connectors at the same time to avoid class version conflicts and the confusion caused for maintenance when multiple versions of Debezium is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org