[GitHub] [skywalking] wu-sheng commented on a diff in pull request #9937: Support MySQL/PostgreSQL cluster mode

[GitBox <gi...@apache.org>]

wu-sheng commented on code in PR #9937:
URL: https://github.com/apache/skywalking/pull/9937#discussion_r1018647957


##########
docs/en/changes/changes.md:
##########
@@ -83,6 +83,7 @@
 * Support `sampledTrace` in LAL.
 * Support multiple rules with different names under the same layer of LAL script.
 * (Optimization) Reduce the buffer size(queue) of MAL(only) metric streams. Set L1 queue size as 1/20, L2 queue size as 1/2.
+* Support MySQL/PostgreSQL cluster mode.

Review Comment:
   ```suggestion
   * Support monitoring MySQL/PostgreSQL in the cluster mode.
   ```
   
   MySQL and PG could be OAP server storage. We need to make this clear.



##########
docs/en/setup/backend/backend-postgresql-monitoring.md:
##########
@@ -64,8 +64,8 @@ SkyWalking leverages [fluentbit](https://fluentbit.io/) or other log agents for
 3. Config PostgreSQL to enable slow log. [Example](../../../../test/e2e-v2/cases/postgresql/postgres-exporter/postgresql.conf).
 
 ### Slow SQL Monitoring
-Slow SQL monitoring provides monitoring of the slow SQL statements of the PostgreSQL server. PostgreSQL server is cataloged as a `Layer: POSTGRESQL` `Service` in OAP.
-
+Slow SQL monitoring provides monitoring of the slow SQL statements of the PostgreSQL server. PostgreSQL Cluster is cataloged as a `Layer: POSTGRESQL` `Service` in OAP.
+A PostgreSQL Server is cataloged as a `Instance` in OAP.

Review Comment:
   Same as above.



##########
docs/en/setup/backend/backend-mysql-monitoring.md:
##########
@@ -14,7 +14,8 @@ SkyWalking leverages prometheus/mysqld_exporter for collecting metrics data. It
 3. Config SkyWalking [OpenTelemetry receiver](opentelemetry-receiver.md).
 
 ### MySQL Monitoring
-MySQL monitoring provides monitoring of the status and resources of the MySQL server. MySQL server is cataloged as a `Layer: MYSQL` `Service` in OAP.
+MySQL monitoring provides monitoring of the status and resources of the MySQL server. MySQL cluster is cataloged as a `Layer: MYSQL` `Service` in OAP.
+A MySQL Server is cataloged as a `Instance` in OAP.

Review Comment:
   ```suggestion
   Each MySQL server is cataloged as an `Instance` in OAP.
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org