You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by jun aoki <ju...@gmail.com> on 2015/10/22 20:59:30 UTC
Review Request 39568: error message is not accurate when a directory
field value has a space
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39568/
-----------------------------------------------------------
Review request for Ambari.
Bugs: AMBARI-13158
https://issues.apache.org/jira/browse/AMBARI-13158
Repository: ambari
Description
-------
when, for example, dfs.datanode.data.dir.mount.file field in Configs tab has a file path with a space, it warns "Must be a slash or drive at the start", which is not accurate.
Diffs
-----
ambari-web/app/models/configs/objects/service_config_property.js d58731c
Diff: https://reviews.apache.org/r/39568/diff/
Testing
-------
Thanks,
jun aoki
Re: Review Request 39568: error message is not accurate when a
directory field value has a space
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39568/#review103642
-----------------------------------------------------------
Ship it!
Ship It!
- Jayush Luniya
On Oct. 22, 2015, 6:59 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39568/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 6:59 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-13158
> https://issues.apache.org/jira/browse/AMBARI-13158
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when, for example, dfs.datanode.data.dir.mount.file field in Configs tab has a file path with a space, it warns "Must be a slash or drive at the start", which is not accurate.
>
>
> Diffs
> -----
>
> ambari-web/app/models/configs/objects/service_config_property.js d58731c
>
> Diff: https://reviews.apache.org/r/39568/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 39568: error message is not accurate when a
directory field value has a space
Posted by jun aoki <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39568/
-----------------------------------------------------------
(Updated Oct. 23, 2015, 12:10 a.m.)
Review request for Ambari.
Bugs: AMBARI-13158
https://issues.apache.org/jira/browse/AMBARI-13158
Repository: ambari
Description
-------
when, for example, dfs.datanode.data.dir.mount.file field in Configs tab has a file path with a space, it warns "Must be a slash or drive at the start", which is not accurate.
Diffs
-----
ambari-web/app/models/configs/objects/service_config_property.js d58731c
Diff: https://reviews.apache.org/r/39568/diff/
Testing
-------
Thanks,
jun aoki
Re: Review Request 39568: error message is not accurate when a
directory field value has a space
Posted by jun aoki <ju...@gmail.com>.
> On Oct. 22, 2015, 7:58 p.m., Alejandro Fernandez wrote:
> > Jun, can you add the branch to the code review and the Jira? I assume this is for trunk.
Sorry. will do!
- jun
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39568/#review103648
-----------------------------------------------------------
On Oct. 22, 2015, 6:59 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39568/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 6:59 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-13158
> https://issues.apache.org/jira/browse/AMBARI-13158
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when, for example, dfs.datanode.data.dir.mount.file field in Configs tab has a file path with a space, it warns "Must be a slash or drive at the start", which is not accurate.
>
>
> Diffs
> -----
>
> ambari-web/app/models/configs/objects/service_config_property.js d58731c
>
> Diff: https://reviews.apache.org/r/39568/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 39568: error message is not accurate when a
directory field value has a space
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39568/#review103648
-----------------------------------------------------------
Jun, can you add the branch to the code review and the Jira? I assume this is for trunk.
- Alejandro Fernandez
On Oct. 22, 2015, 6:59 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39568/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 6:59 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-13158
> https://issues.apache.org/jira/browse/AMBARI-13158
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when, for example, dfs.datanode.data.dir.mount.file field in Configs tab has a file path with a space, it warns "Must be a slash or drive at the start", which is not accurate.
>
>
> Diffs
> -----
>
> ambari-web/app/models/configs/objects/service_config_property.js d58731c
>
> Diff: https://reviews.apache.org/r/39568/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 39568: error message is not accurate when a
directory field value has a space
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39568/#review103646
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Oct. 22, 2015, 6:59 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39568/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 6:59 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-13158
> https://issues.apache.org/jira/browse/AMBARI-13158
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when, for example, dfs.datanode.data.dir.mount.file field in Configs tab has a file path with a space, it warns "Must be a slash or drive at the start", which is not accurate.
>
>
> Diffs
> -----
>
> ambari-web/app/models/configs/objects/service_config_property.js d58731c
>
> Diff: https://reviews.apache.org/r/39568/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> jun aoki
>
>
Re: Review Request 39568: error message is not accurate when a
directory field value has a space
Posted by John Speidel <js...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39568/#review103643
-----------------------------------------------------------
Ship it!
Would be nicer to have the validator provide the validation error instead of hard coding it.
- John Speidel
On Oct. 22, 2015, 6:59 p.m., jun aoki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39568/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2015, 6:59 p.m.)
>
>
> Review request for Ambari.
>
>
> Bugs: AMBARI-13158
> https://issues.apache.org/jira/browse/AMBARI-13158
>
>
> Repository: ambari
>
>
> Description
> -------
>
> when, for example, dfs.datanode.data.dir.mount.file field in Configs tab has a file path with a space, it warns "Must be a slash or drive at the start", which is not accurate.
>
>
> Diffs
> -----
>
> ambari-web/app/models/configs/objects/service_config_property.js d58731c
>
> Diff: https://reviews.apache.org/r/39568/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> jun aoki
>
>