You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by assafmendelson <gi...@git.apache.org> on 2017/06/20 14:29:27 UTC
[GitHub] spark pull request #18363: [Spark-21123][Docs][Structured Streaming] Options...
GitHub user assafmendelson opened a pull request:
https://github.com/apache/spark/pull/18363
[Spark-21123][Docs][Structured Streaming] Options for file stream source are in a wrong table - version to fix 2.1
## What changes were proposed in this pull request?
The description for several options of File Source for structured streaming appeared in the File Sink description instead.
This commit continues on PR #18342 and targets the fixes for the documentation of version spark version 2.1
## How was this patch tested?
Built the documentation by SKIP_API=1 jekyll build and visually inspected the structured streaming programming guide.
@zsxwing This is the PR to fix version 2.1 as discussed in PR #18342
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/assafmendelson/spark spark-21123-for-spark2.1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18363.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18363
----
commit 595ffd7f029f65f8741d554b81ce0e1f0f66c322
Author: assafmendelson <as...@gmail.com>
Date: 2017-06-20T14:25:12Z
File source options for spark 2.1 appeared under File sink
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18363: [Spark-21123][Docs][Structured Streaming] Options for fi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18363
**[Test build #78304 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78304/testReport)** for PR 18363 at commit [`595ffd7`](https://github.com/apache/spark/commit/595ffd7f029f65f8741d554b81ce0e1f0f66c322).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18363: [Spark-21123][Docs][Structured Streaming] Options for fi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18363
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18363: [Spark-21123][Docs][Structured Streaming] Options for fi...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/18363
@assafmendelson Thanks! I merged it. Could you close this PR, please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18363: [Spark-21123][Docs][Structured Streaming] Options...
Posted by assafmendelson <gi...@git.apache.org>.
Github user assafmendelson closed the pull request at:
https://github.com/apache/spark/pull/18363
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18363: [Spark-21123][Docs][Structured Streaming] Options for fi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18363
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18363: [Spark-21123][Docs][Structured Streaming] Options for fi...
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/18363
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18363: [Spark-21123][Docs][Structured Streaming] Options for fi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18363
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/78304/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18363: [Spark-21123][Docs][Structured Streaming] Options for fi...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18363
**[Test build #78304 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/78304/testReport)** for PR 18363 at commit [`595ffd7`](https://github.com/apache/spark/commit/595ffd7f029f65f8741d554b81ce0e1f0f66c322).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org