You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/26 13:44:07 UTC
[GitHub] [dolphinscheduler] SbloodyS opened a new issue, #10257: [API][Module Name] Suggest refactor the backend api
SbloodyS opened a new issue, #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar feature requirement.
### Description
Refactor reason:
- Use restful style to unify API specifications
- Solve the current incomplete API document and reduce the threshold of API use
- Improve API reusability
- Reduce unnecessary data return and improve performance
- Improve the readability of the code and reduce the maintenance cost
First of all, we need to sort out all the current API problems and modification suggestions. Then we can plan for the next step.
### Use case
Current API:
### Index page
* [] xxx
### Project manage
#### Workflow Monitor
* [] xxx
#### Workflow Relationship
* [] xxx
#### Workflow Definition
* [] xxx
#### Workflow Instance
* [] xxx
#### Task Definition
* [] xxx
#### Task Instance
* [] xxx
### Datasource center
* [] xxx
### Resource center
* [] xxx
### Dataquality center
* [] xxx
### Mornitoring center
* [] xxx
### Security center
### Related issues
_No response_
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1156231698
May I pick the monitor page? Thx #10458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1140444919
> I found that our restful api standard doc shows that the api include path `/api/dolphinscheduler/`. But in `dev` branch the path `/api/` did not exists. Should we change the doc or use `/api/v2` path? @caishunfeng @zhongjiajie
I think we should correct the document, and FYI, I think one of this resource it is because our documentation are in too many places, and developer documen without version, I create an issue https://github.com/apache/dolphinscheduler/issues/9927.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1172177957
> This is a good refactoring plan for me. The audit log has made an Around aspect to all non-query/statistics APIs, and customized processing based on the current API's local method name and interaction data. After the refactoring, the processing method involving the API will be more convenient and unified, so count me in please @SbloodyS
Hi @WangJPLeo May I ask whether you are working on the auditing feature currently?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1173311540
> > > This is a good refactoring plan for me. The audit log has made an Around aspect to all non-query/statistics APIs, and customized processing based on the current API's local method name and interaction data. After the refactoring, the processing method involving the API will be more convenient and unified, so count me in please @SbloodyS
> >
> >
> > Hi @WangJPLeo May I ask whether you are working on the auditing feature currently?
>
> yes, an audit log has been implemented in the project now. @EricGao888
@WangJPLeo Thx for the reply. May I ask whether you are going to take this one? #10295 I haven't worked on it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [DSIP-7] [API] Suggest refactor the backend api [dolphinscheduler]
Posted by "xushoubao (via GitHub)" <gi...@apache.org>.
xushoubao commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1848642656
你好，来件已收到，我会及时回复！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1184546711
> can i participate in this ，such as ResourcesController ，but I'm not sure how to reactor 。for example read some reactor PR and ResourcesController code ,what i need to do is
>
> 1. rename ResourcesController to ResourcesV2Controller ,requestmap to /v2/xxxxx
> 2. replace The input and output parameters if map or json to POJO
> 3. define explicit error info or message
> 4. supplement Api doc if have enumeration
>
> ❓
Very welcome to participate. The fourth point is to add that not only enumeration values, but also sample data is required for each parameter. You can choose the part you want to participate in and tell me after creating the issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liguotian commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
liguotian commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1183218791
can i participate in this ，such as ResourcesController ，but I'm not sure how to reactor 。for example read some reactor PR and ResourcesController code ,what i need to do is
1. rename ResourcesController to ResourcesV2Controller ,requestmap to /v2/xxxxx
2. replace The input and output parameters if map or json to POJO
3. define explicit error info or message
4. supplement Api doc if have enumeration
❓
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1149400928
> Count me in
I will make a list of all the backend api of ds for everyone to choose in a few days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] tracehh commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
tracehh commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1253108962
@SbloodyS I take EnvironmentV2Controller #12075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guodongym commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
guodongym commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1153157735
Count me in @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1156243674
> Just `AccessTokenController ` && `LoginController` first.
Sure. Please let me know after your issue is created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] WangJPLeo commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
WangJPLeo commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1173312609
> > > > This is a good refactoring plan for me. The audit log has made an Around aspect to all non-query/statistics APIs, and customized processing based on the current API's local method name and interaction data. After the refactoring, the processing method involving the API will be more convenient and unified, so count me in please @SbloodyS
> > >
> > >
> > > Hi @WangJPLeo May I ask whether you are working on the auditing feature currently?
> >
> >
> > yes, an audit log has been implemented in the project now. @EricGao888
>
> @WangJPLeo Thx for the reply. May I ask whether you are going to take this one? #10295 I haven't worked on it yet.
oK, I'll follow up on this issue. @EricGao888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1232774540
> I see that there are many functions inside the taskinstancecontroller，If I participate in the TaskInstanceController task, do I only need to modify the queryTaskListPaging forceTaskSuccess functions in TaskInstanceV2Controller?
Yes. You are right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [DSIP-7] [API] Suggest refactor the backend api [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS closed issue #10257: [DSIP-7] [API] Suggest refactor the backend api
URL: https://github.com/apache/dolphinscheduler/issues/10257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] xushoubao commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
xushoubao commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1250336798
你好，来件已收到，我会及时回复！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1175845004
> For this interface refactoring, I recommend replacing `process` in the project with `workflow`, because the word `process` will be gradually eliminated in the front-end display and will also be replaced by `workflow`. @SbloodyS
yes, and all of our UI using workflow instead of process. and developers is another kind of users for DolphinScheduler
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] czeming commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
czeming commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1156258148
Count me in @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1156234254
> @SbloodyS May I pick the monitor page? Thx #10458
Sure. I've assigned it to you. Looking forward to your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1139373701
> 1. Do you guys have any goods suggestions for the new api' path? For example using `/v2` to distinguish it from the old api.
> 2. Currently we use `{code: 0, msg: "成功", data: {}, failed: false, success: true}` as our api's response structure. I suggest remove meaningless `failed` and `success` and use `code` to judge success or failed. That is `{code: 0, msg: "成功", data: {}}`.
>
> @zhongjiajie @songjianet @caishunfeng
Argee with you. we would better to use `/v2` api.
And I found the doc of resful api standard: https://dolphinscheduler.apache.org/zh-cn/development/api-standard.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1156262679
> Count me in @SbloodyS
Sure. Which do you want to take?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1185101904
> OK , I have create issue #10983 for refactor api org.apache.dolphinscheduler.api.controller.ResourcesController. 😁
I've assigned it to you. Looking forward to your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Zzih commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
Zzih commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1232564425
I see that there are many functions inside the taskinstancecontroller，If I participate in the TaskInstanceController task, do I only need to modify the queryTaskListPaging forceTaskSuccess functions in TaskInstanceV2Controller?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1253086575
> Can I take K8sNamespaceController? or should i start contributing from issues with good first issue label?
It's recommanded to start from `good first issue`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] MichaelDeSteven commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
MichaelDeSteven commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1193320307
Plz assgin me `Workflow Definition` task.
I have create issue https://github.com/apache/dolphinscheduler/issues/11129 for refactor api org.apache.dolphinscheduler.api.controller.ProcessDefinitionController.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] xushoubao commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
xushoubao commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1139226809
你好，来件已收到，我会及时回复！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [DSIP-7] [API] Suggest refactor the backend api [dolphinscheduler]
Posted by "xushoubao (via GitHub)" <gi...@apache.org>.
xushoubao commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-4043336220
你好，来件已收到，我会及时回复！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
songjianet commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1175126227
For this interface refactoring, I recommend replacing `process` in the project with `workflow`, because the word `process` will be gradually eliminated in the front-end display and will also be replaced by `workflow`. @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] MichaelDeSteven commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
MichaelDeSteven commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1193687303
@SbloodyS hi, I got a rename problem.
<img width="492" alt="image" src="https://user-images.githubusercontent.com/51652084/180722010-e0f056f7-f9a8-402c-9c77-e6000ff86d4a.png">
we want rename `process` to `workflow`. So which `RequestMapping` path is best choice?
1. `v2/projects/{projectCode}/process-definition`
2. `projects/{projectCode}/workflow-definition`
3. `v2/projects/{projectCode}/workflow-definition`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [DSIP-7] [API] Suggest refactor the backend api [dolphinscheduler]
Posted by "zzzk1 (via GitHub)" <gi...@apache.org>.
zzzk1 commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1848642578
I would like to ask if there are any unfinished tasks for this issue that you can assign to me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #10257: [API][Module Name] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1138595805
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://join.slack.com/t/asf-dolphinscheduler/shared_invite/zt-omtdhuio-_JISsxYhiVsltmC5h38yfw) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1153928318
Super coooool! Count me in plz @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1172199238
> This is a good refactoring plan for me. The audit log has made an Around aspect to all non-query/statistics APIs, and customized processing based on the current API's local method name and interaction data. After the refactoring, the processing method involving the API will be more convenient and unified, so count me in please @SbloodyS
Sure. Which do you want to take?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] xushoubao commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
xushoubao commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1172174521
你好，来件已收到，我会及时回复！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liqingwang commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
liqingwang commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1156236028
May I pick the Security center? @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1232775144
> Plz assgin me Task Instance task.
I've assigned to you. Looking forward to your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liguotian commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
liguotian commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1185100797
>
OK , I have create issue #10983 for refactor api org.apache.dolphinscheduler.api.controller.ResourcesController. 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] WangJPLeo commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
WangJPLeo commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1172174111
This is a good refactoring plan for me. The audit log has made an Around aspect to all non-query/statistics APIs, and customized processing based on the current API's local method name and interaction data. After the refactoring, the processing method involving the API will be more convenient and unified, so count me in please @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1173313052
> > > > > This is a good refactoring plan for me. The audit log has made an Around aspect to all non-query/statistics APIs, and customized processing based on the current API's local method name and interaction data. After the refactoring, the processing method involving the API will be more convenient and unified, so count me in please @SbloodyS
> > > >
> > > >
> > > > Hi @WangJPLeo May I ask whether you are working on the auditing feature currently?
> > >
> > >
> > > yes, an audit log has been implemented in the project now. @EricGao888
> >
> >
> > @WangJPLeo Thx for the reply. May I ask whether you are going to take this one? #10295 I haven't worked on it yet.
> > oK, I'll follow up on this issue. @EricGao888
@WangJPLeo Cool, thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] WangJPLeo commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
WangJPLeo commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1173310628
> > This is a good refactoring plan for me. The audit log has made an Around aspect to all non-query/statistics APIs, and customized processing based on the current API's local method name and interaction data. After the refactoring, the processing method involving the API will be more convenient and unified, so count me in please @SbloodyS
>
> Hi @WangJPLeo May I ask whether you are working on the auditing feature currently?
yes, an audit log has been implemented in the project now. @EricGao888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1193697838
> @SbloodyS hi, I got a rename problem. <img alt="image" width="492" src="https://user-images.githubusercontent.com/51652084/180722010-e0f056f7-f9a8-402c-9c77-e6000ff86d4a.png"> we want rename `process` to `workflow`. So which `RequestMapping` path is best choice?
>
> 1. `v2/projects/{projectCode}/process-definition`
> 2. `projects/{projectCode}/workflow-definition`
> 3. `v2/projects/{projectCode}/workflow-definition`
It's better to use `v2/projects/{projectCode}/workflow-definition`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liqingwang commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
liqingwang commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1149389661
Count me in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1156225591
Some apis to be reconstructed have been added to this issue. Please reply the controller name and its function name you want to participate in and the issue you created. I will link it to this issue and assign it to you. Please feel free to take it. @liqingwang @guodongym @EricGao888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liqingwang commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
liqingwang commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1156251112
#10459 Thx
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1156264148
> @SbloodyS May I pick the Datasource center? Thx #10460
Sure. I've assigned to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1158567648
> Count me in plz. Just ProjectController first. @SbloodyS
Sure. Looking forward to your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] tracehh commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
tracehh commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1158563771
Count me in plz. Just ProjectController first. @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] xushoubao commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
xushoubao commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1232564777
你好，来件已收到，我会及时回复！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Zzih commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
Zzih commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1232603774
Plz assgin me Task Instance task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] etcZYP commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
etcZYP commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1250336733
Plz assign me K8sNamespaceController
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1175845894
> For this interface refactoring, I recommend replacing `process` in the project with `workflow`, because the word `process` will be gradually eliminated in the front-end display and will also be replaced by `workflow`. @SbloodyS
Agreed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] WangJPLeo commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
WangJPLeo commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1173311831
> > This is a good refactoring plan for me. The audit log has made an Around aspect to all non-query/statistics APIs, and customized processing based on the current API's local method name and interaction data. After the refactoring, the processing method involving the API will be more convenient and unified, so count me in please @SbloodyS
>
> Sure. Which do you want to take?
first is ProcessDefinitionController. @SbloodyS
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1139337241
1. Do you guys have any goods suggestions for the new api' path? For example using ```/v2``` to distinguish it from the old api.
2. Currently we use ```{code: 0, msg: "成功", data: {}, failed: false, success: true}``` as our api's response structure. I suggest remove meaningless ```failed``` and ```success``` and use ```code``` to judge success or failed. That is ```{code: 0, msg: "成功", data: {}}```.
@zhongjiajie @songjianet @caishunfeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1175108334
> > > This is a good refactoring plan for me. The audit log has made an Around aspect to all non-query/statistics APIs, and customized processing based on the current API's local method name and interaction data. After the refactoring, the processing method involving the API will be more convenient and unified, so count me in please @SbloodyS
> >
> >
> > Sure. Which do you want to take?
>
> first is ProcessDefinitionController. @SbloodyS
Please create the associate issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] EricGao888 commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
EricGao888 commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1175130594
> For this interface refactoring, I recommend replacing `process` in the project with `workflow`, because the word `process` will be gradually eliminated in the front-end display and will also be replaced by `workflow`. @SbloodyS
+1, the term `process` sometimes a little bit confusing. `Workflow` is more commonly used in scheduler and it is always good to keep front-end and backend naming consistent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1193457690
> Plz assgin me `Workflow Definition` task. I have create issue #11129 for refactor api org.apache.dolphinscheduler.api.controller.ProcessDefinitionController.
I've assigned it to you. Looking forward to your contribution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] lvshaokang commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
lvshaokang commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1252134448
@zhongjiajie Would you assign me `WorkerGroupController` task, I will attempt to finish it, thk! BTW, should I create an issue first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Zzih commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
Zzih commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1235205923
Plz assgin me Workflow Monitor task and help me review RPhttps://github.com/apache/dolphinscheduler/pull/11747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] songjianet commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
songjianet commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1139412365
> > 1. Do you guys have any goods suggestions for the new api' path? For example using `/v2` to distinguish it from the old api.
> > 2. Currently we use `{code: 0, msg: "成功", data: {}, failed: false, success: true}` as our api's response structure. I suggest remove meaningless `failed` and `success` and use `code` to judge success or failed. That is `{code: 0, msg: "成功", data: {}}`.
> >
> > @zhongjiajie @songjianet @caishunfeng
>
> Argee with you. we would better to use `/v2` api. And I found the doc of resful api standard: https://dolphinscheduler.apache.org/zh-cn/development/api-standard.html
This lacks the patch request method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1139226618
Thanks @SbloodyS and @songjianet to bring this up, and it is worth the label `DSIP`. It looks good overall, I think maybe we could also add some check/tests and out API style itself to make sure we are restful and make sure out API docs same as our code. I am not sure whether exists this tools or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1139479372
I found that our restful api standard doc shows that the api include path ```/api/dolphinscheduler/```. But in ```dev``` branch the path ```/api/``` did not exists. Should we change the doc or use ```/api/v2``` path? @caishunfeng @zhongjiajie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1153158061
> Count me in @SbloodyS
Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] guodongym commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
guodongym commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1156263392
@SbloodyS May I pick the Datasource center? Thx #10460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1156237955
> AccessTokenController
What you want is the whole security center or just the ```AccessTokenController```? ```Accesstokencontroller``` is only a part of the security center.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] liqingwang commented on issue #10257: [DSIP-7] [API] Suggest refactor the backend api
Posted by GitBox <gi...@apache.org>.
liqingwang commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-1156241551
Just `AccessTokenController ` && `LoginController` first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [DSIP-7] [API] Suggest refactor the backend api [dolphinscheduler]
Posted by "Sud0x67 (via GitHub)" <gi...@apache.org>.
Sud0x67 commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-3140971832
Hi @SbloodyS, it seems there’s still quite a bit of work remaining on this DSIP.
I’m wondering what the current status is, as I’m working on building a user-friendly client based on these APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [DSIP-7] [API] Suggest refactor the backend api [dolphinscheduler]
Posted by "xushoubao (via GitHub)" <gi...@apache.org>.
xushoubao commented on issue #10257:
URL: https://github.com/apache/dolphinscheduler/issues/10257#issuecomment-3140973208
你好，来件已收到，我会及时回复！
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org