[GitHub] nifi pull request #2334: Nifi 3970

[MikeThomsen <gi...@git.apache.org>]

GitHub user MikeThomsen opened a pull request:

    https://github.com/apache/nifi/pull/2334

    Nifi 3970

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MikeThomsen/nifi NIFI-3970

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2334.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2334
    
----
commit 1ab47c2ac332be41073e7f5c7a2ee3052e3b4e68
Author: Matthew Burgess <ma...@apache.org>
Date:   2017-09-06T17:01:22Z

    NIFI-3970: Add CSVRecordLookupService

commit b216a1df8ef9631a1dd0cc31a8ec0eacb9a6a668
Author: Mike Thomsen <mi...@gmail.com>
Date:   2017-12-01T13:45:39Z

    NIFI-3970 added changes from a code review.

----


---

[GitHub] nifi issue #2334: Nifi 3970

[MikeThomsen <gi...@git.apache.org>]

Github user MikeThomsen commented on the issue:

    https://github.com/apache/nifi/pull/2334
  
    @mattyb149 Per your request.
    
    @markap14 I forked matt's branch and went through your feedback. It should all be here.


---

[GitHub] nifi issue #2334: NIFI-3970: Add CSVRecordLookupService

[mattyb149 <gi...@git.apache.org>]

Github user mattyb149 commented on the issue:

    https://github.com/apache/nifi/pull/2334
  
    +1 LGTM, thanks for taking this over and getting it past the finish line! I built and ran with tests and contrib-check, and ran using a couple of lookups and settings (and multiple tasks). Merging to master


---

[GitHub] nifi pull request #2334: NIFI-3970: Add CSVRecordLookupService

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/nifi/pull/2334


---