You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/06/18 19:56:49 UTC

[Impala-ASF-CR] IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit

Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/23047


Change subject: IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit
......................................................................

IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit

TestExprDepthLimit still hit stack overflow when at 8x deeper than
Expr.EXPR_DEPTH_LIMIT (1000). This patch lower the multiple further to
2x so that the expression tree does not hit stack overflow during
creation.

Testing:
Pass FE_TEST with JDK17.

Change-Id: If77a64435091459fa8a7d7bb5218a8eb0895802c
---
M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
1 file changed, 4 insertions(+), 4 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/47/23047/1
-- 
To view, visit http://gerrit.cloudera.org:8080/23047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If77a64435091459fa8a7d7bb5218a8eb0895802c
Gerrit-Change-Number: 23047
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23047 )

Change subject: IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/12052/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/23047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If77a64435091459fa8a7d7bb5218a8eb0895802c
Gerrit-Change-Number: 23047
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jun 2025 21:38:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23047 )

Change subject: IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/23047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If77a64435091459fa8a7d7bb5218a8eb0895802c
Gerrit-Change-Number: 23047
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Jun 2025 03:40:41 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit

Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23047 )

Change subject: IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit
......................................................................


Patch Set 1: Code-Review+2

This makes sense to me


-- 
To view, visit http://gerrit.cloudera.org:8080/23047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If77a64435091459fa8a7d7bb5218a8eb0895802c
Gerrit-Change-Number: 23047
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jun 2025 21:34:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/23047 )

Change subject: IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit
......................................................................

IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit

TestExprDepthLimit still hit stack overflow when at 8x deeper than
Expr.EXPR_DEPTH_LIMIT (1000). This patch lower the multiple further to
2x so that the expression tree does not hit stack overflow during
creation.

Testing:
Pass FE_TEST with JDK17.

Change-Id: If77a64435091459fa8a7d7bb5218a8eb0895802c
Reviewed-on: http://gerrit.cloudera.org:8080/23047
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/test/java/org/apache/impala/analysis/AnalyzeExprsTest.java
1 file changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Joe McDonnell: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/23047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If77a64435091459fa8a7d7bb5218a8eb0895802c
Gerrit-Change-Number: 23047
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>

[Impala-ASF-CR] IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/23047 )

Change subject: IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/19533/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/23047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If77a64435091459fa8a7d7bb5218a8eb0895802c
Gerrit-Change-Number: 23047
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jun 2025 20:24:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit

Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23047 )

Change subject: IMPALA-13649: (addendum) lower the multiple in TestExprDepthLimit
......................................................................


Patch Set 1:

> Patch Set 1: Code-Review+2
> 
> This makes sense to me

Thanks Joe!


-- 
To view, visit http://gerrit.cloudera.org:8080/23047
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If77a64435091459fa8a7d7bb5218a8eb0895802c
Gerrit-Change-Number: 23047
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 18 Jun 2025 21:38:53 +0000
Gerrit-HasComments: No