You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Jeremy Thomerson <je...@wickettraining.com> on 2010/12/16 23:53:28 UTC
Any objection to adding RequestCycle#getRequestTargetStack()?
Would there be any reason we shouldn't allow developers to get an
unmodifiable reference to the transient requestTargets stack in
RequestCycle?
--
Jeremy Thomerson
http://wickettraining.com
*Need a CMS for Wicket? Use Brix! http://brixcms.org*
Re: Any objection to adding RequestCycle#getRequestTargetStack()?
Posted by Igor Vaynberg <ig...@gmail.com>.
the reason is that we are exposing the fact that there is a stack. if
we wanted to reimplement this later without a stack we would not be
able to without api breaks. i dont feel strongly about it because i
dont think we are likely to reimplement the thing, so do whatever you
want.
-igor
On Fri, Dec 17, 2010 at 8:45 AM, Jeremy Thomerson
<je...@wickettraining.com> wrote:
> On Fri, Dec 17, 2010 at 12:28 AM, Igor Vaynberg <ig...@gmail.com>wrote:
>
>> why?
>>
>
> Someone asked me about it, and although I think there are better ways, I
> couldn't see a reason that we shouldn't allow access, and wondered what
> others thought. The reason was for some kind of in-depth request logger
> that could log not only what was originally requested, but what eventually
> actually ended up being the response. i.e., look at the request target
> stack and see that the original request target was a form submission on page
> X, and last target was a page request target for Y, or a download target,
> etc....
>
>
> --
> Jeremy Thomerson
> http://wickettraining.com
> *Need a CMS for Wicket? Use Brix! http://brixcms.org*
>
Re: Any objection to adding RequestCycle#getRequestTargetStack()?
Posted by Jeremy Thomerson <je...@wickettraining.com>.
On Fri, Dec 17, 2010 at 12:28 AM, Igor Vaynberg <ig...@gmail.com>wrote:
> why?
>
Someone asked me about it, and although I think there are better ways, I
couldn't see a reason that we shouldn't allow access, and wondered what
others thought. The reason was for some kind of in-depth request logger
that could log not only what was originally requested, but what eventually
actually ended up being the response. i.e., look at the request target
stack and see that the original request target was a form submission on page
X, and last target was a page request target for Y, or a download target,
etc....
--
Jeremy Thomerson
http://wickettraining.com
*Need a CMS for Wicket? Use Brix! http://brixcms.org*
Re: Any objection to adding RequestCycle#getRequestTargetStack()?
Posted by Igor Vaynberg <ig...@gmail.com>.
why?
-igor
On Fri, Dec 17, 2010 at 12:53 AM, Jeremy Thomerson
<je...@wickettraining.com> wrote:
> Would there be any reason we shouldn't allow developers to get an
> unmodifiable reference to the transient requestTargets stack in
> RequestCycle?
>
> --
> Jeremy Thomerson
> http://wickettraining.com
> *Need a CMS for Wicket? Use Brix! http://brixcms.org*
>