You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/03/12 19:56:05 UTC

[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #20018: [v1.x] Add AWDRNN Pratrained model test

Zha0q1 opened a new pull request #20018:
URL: https://github.com/apache/incubator-mxnet/pull/20018


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on a change in pull request #20018: [v1.x] Add AWDRNN Pratrained model test

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on a change in pull request #20018:
URL: https://github.com/apache/incubator-mxnet/pull/20018#discussion_r594562252



##########
File path: tests/python-pytest/onnx/test_onnxruntime.py
##########
@@ -815,3 +815,66 @@ def test_dynamic_shape_bert_inference_onnxruntime(tmp_path, model):
 
     finally:
         shutil.rmtree(tmp_path)
+
+
+@with_seed()
+@pytest.mark.parametrize('model_name', [('awd_lstm_lm_600', 600), ('awd_lstm_lm_1150', 1150)])
+@pytest.mark.parametrize('seq_length', [16, 32])

Review comment:
       Yeah I can change them to 96/128, which are two commonly used lengths




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 merged pull request #20018: [v1.x] Add AWDRNN Pratrained model test

Posted by GitBox <gi...@apache.org>.
Zha0q1 merged pull request #20018:
URL: https://github.com/apache/incubator-mxnet/pull/20018


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] waytrue17 commented on a change in pull request #20018: [v1.x] Add AWDRNN Pratrained model test

Posted by GitBox <gi...@apache.org>.
waytrue17 commented on a change in pull request #20018:
URL: https://github.com/apache/incubator-mxnet/pull/20018#discussion_r594552750



##########
File path: tests/python-pytest/onnx/test_onnxruntime.py
##########
@@ -815,3 +815,66 @@ def test_dynamic_shape_bert_inference_onnxruntime(tmp_path, model):
 
     finally:
         shutil.rmtree(tmp_path)
+
+
+@with_seed()
+@pytest.mark.parametrize('model_name', [('awd_lstm_lm_600', 600), ('awd_lstm_lm_1150', 1150)])
+@pytest.mark.parametrize('seq_length', [16, 32])

Review comment:
       Shall we also test other seq_length like 128 or 256?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #20018: [v1.x] Add AWDRNN Pratrained model test

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #20018:
URL: https://github.com/apache/incubator-mxnet/pull/20018#issuecomment-797719004


   Hey @Zha0q1 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [edge, centos-gpu, centos-cpu, windows-cpu, sanity, miscellaneous, website, windows-gpu, unix-cpu, clang, unix-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org