You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Filip Maj (Updated) (JIRA)" <ji...@apache.org> on 2012/04/08 20:06:18 UTC
[jira] [Updated] (CB-462) Refactor accelerometer JS <-> native
interactions
[ https://issues.apache.org/jira/browse/CB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Filip Maj updated CB-462:
-------------------------
Description:
Similar to CB-359.
We use a completely different set of native actions to control Geolocation, Accelerometer and Compass sensor APIs. These all have identical APIs and really should be implemented in the same way.
For accelerometer, there is no reason to need a {{setTimeout}} and {{getTimeout}} native action.
Should use the pattern employed in CB-359 to implement the accel sensor API.
CordovaJS should also be wrapping the error and success callbacks in {{accelerometer}} calls and making sure the right {{Acceleration}} and {{Error}} objects are passed to the user callbacks. Also need to add more unit tests to CordovaJS to be testing for all of this.
was:
Similar to CB-359.
We use a completely different set of native actions to control Geolocation, Accelerometer and Compass sensor APIs. These all have identical APIs and really should be implemented in the same way.
For accelerometer, there is no reason to need a {{setTimeout}} and {{getTimeout}} native action.
Should use the pattern employed in CB-359 to implement the accel sensor API.
> Refactor accelerometer JS <-> native interactions
> -------------------------------------------------
>
> Key: CB-462
> URL: https://issues.apache.org/jira/browse/CB-462
> Project: Apache Callback
> Issue Type: Improvement
> Components: CordovaJS
> Affects Versions: 1.6.0
> Reporter: Filip Maj
> Assignee: Filip Maj
> Fix For: 1.7.0
>
>
> Similar to CB-359.
> We use a completely different set of native actions to control Geolocation, Accelerometer and Compass sensor APIs. These all have identical APIs and really should be implemented in the same way.
> For accelerometer, there is no reason to need a {{setTimeout}} and {{getTimeout}} native action.
> Should use the pattern employed in CB-359 to implement the accel sensor API.
> CordovaJS should also be wrapping the error and success callbacks in {{accelerometer}} calls and making sure the right {{Acceleration}} and {{Error}} objects are passed to the user callbacks. Also need to add more unit tests to CordovaJS to be testing for all of this.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira