You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/20 00:57:32 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #10415: Add missing deprecated classes

mik-laj commented on a change in pull request #10415:
URL: https://github.com/apache/airflow/pull/10415#discussion_r473490482



##########
File path: tests/deprecated_classes.py
##########
@@ -15,6 +15,10 @@
 # specific language governing permissions and limitations
 # under the License.
 HOOKS = [
+    (

Review comment:
       This import is not valid. We do not expect users to import BaseHook by:
   ```
   from airflow.hooks.filesystem import BaseHook
   ```
   BaseHook should be imported at all times, as shown below.
   ```
   from airflow.hooks.base_hook import BaseHook
   ```
   There is a broken backwards compatibility here, but we can't prevent API misuse as Python is too flexible




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org