You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/08 17:30:26 UTC
[GitHub] [arrow] paleolimbot opened a new pull request, #12842: ARROW-16156: [R] Clarify warning message for features not turned on in .onAttach()
paleolimbot opened a new pull request, #12842:
URL: https://github.com/apache/arrow/pull/12842
After ARROW-15818 (#12564) we get an extra message on package load because "engine" was added to `arrow_info()$capabilities` and few if any users will have this turned on for at least the next release:
```r
library(arrow)
#> See arrow_info() for available features
```
This PR adds "engine" to the list of features we don't message users about and clarifies the message so that it's more clear why it's being shown:
```r
library(arrow)
#> Some features of Arrow C++ are turned off. Run `arrow_info()` for more information.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane commented on a diff in pull request #12842: ARROW-16156: [R] Clarify warning message for features not turned on in .onAttach()
Posted by GitBox <gi...@apache.org>.
jonkeane commented on code in PR #12842:
URL: https://github.com/apache/arrow/pull/12842#discussion_r846392949
##########
r/R/arrow-package.R:
##########
@@ -107,7 +107,12 @@
#
# Let's print a message if some are off
if (some_features_are_off(features)) {
- packageStartupMessage("See arrow_info() for available features")
+ packageStartupMessage(
+ paste(
+ "Some features of Arrow C++ are turned off.",
+ "Run `arrow_info()` for more information."
Review Comment:
```suggestion
"Some features are not enabled in this build of Arrow.",
"Run `arrow_info()` for more information."
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonkeane closed pull request #12842: ARROW-16156: [R] Clarify warning message for features not turned on in .onAttach()
Posted by GitBox <gi...@apache.org>.
jonkeane closed pull request #12842: ARROW-16156: [R] Clarify warning message for features not turned on in .onAttach()
URL: https://github.com/apache/arrow/pull/12842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12842: ARROW-16156: [R] Clarify warning message for features not turned on in .onAttach()
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #12842:
URL: https://github.com/apache/arrow/pull/12842#issuecomment-1094166831
Benchmark runs are scheduled for baseline = 58fe60f59289079f7cb8d88aa195570f22836292 and contender = 961ec771b9bb84b71be3af398e7b3df3e10f291b. 961ec771b9bb84b71be3af398e7b3df3e10f291b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/b2ad2814d91e40bfb4612888475c14af...5a77b3f8cba344e7aa04c7881c99d841/)
[Finished :arrow_down:0.17% :arrow_up:0.04%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/8407f38ad5f9420ea6f2b513440c8b7e...1eea0be431204f95826e70b8d4d85cd8/)
[Failed :arrow_down:0.71% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/1495dfa98c634be791e09ae85e216602...91b9fa1bad224999a779f68e3488ef0e/)
[Finished :arrow_down:0.17% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/03aa31b6d49d4a82ade26229c3190073...01ced03395a449c9829906184ac3c2e0/)
Buildkite builds:
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/482| `961ec771` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/467| `961ec771` test-mac-arm>
[Failed] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/468| `961ec771` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/477| `961ec771` ursa-thinkcentre-m75q>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/481| `58fe60f5` ec2-t3-xlarge-us-east-2>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/466| `58fe60f5` test-mac-arm>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/467| `58fe60f5` ursa-i9-9960x>
[Finished] <https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/476| `58fe60f5` ursa-thinkcentre-m75q>
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] paleolimbot commented on pull request #12842: ARROW-16156: [R] Clarify warning message for features not turned on in .onAttach()
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on PR #12842:
URL: https://github.com/apache/arrow/pull/12842#issuecomment-1093234067
I like it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12842: ARROW-16156: [R] Clarify warning message for features not turned on in .onAttach()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12842:
URL: https://github.com/apache/arrow/pull/12842#issuecomment-1093117349
https://issues.apache.org/jira/browse/ARROW-16156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12842: ARROW-16156: [R] Clarify warning message for features not turned on in .onAttach()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12842:
URL: https://github.com/apache/arrow/pull/12842#issuecomment-1093117381
:warning: Ticket **has no components in JIRA**, make sure you assign one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12842: ARROW-16156: [R] Clarify warning message for features not turned on in .onAttach()
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12842:
URL: https://github.com/apache/arrow/pull/12842#issuecomment-1093117395
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org