You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/10/24 12:19:59 UTC

[GitHub] [incubator-kyuubi] lightning-L opened a new pull request, #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/li…

lightning-L opened a new pull request, #3689:
URL: https://github.com/apache/incubator-kyuubi/pull/3689

   …st engine operation
   
   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/list engine operation

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3689:
URL: https://github.com/apache/incubator-kyuubi/pull/3689#discussion_r1004087378


##########
docs/client/rest/rest_api.md:
##########
@@ -349,6 +349,43 @@ Gets the local log lines from this batch.
 | logRowSet | The log lines     | List of sting |
 | rowCount  | The log row count | Int           |
 
+## Admin Resource
+
+### POST /admin/refresh/hadoop_conf
+
+Refresh the Kyuubi server hadoop conf.
+
+### DELETE /admin/engine
+
+Delete specified engine.
+
+#### Request Parameters
+
+| Name                    | Description                   | Type             |
+|:------------------------|:------------------------------| :--------------- |
+| type                    | the engine type               | String(optional) |
+| sharelevel              | the engine share level        | String(optional) |
+| subdomain               | the engine subdomain          | String(optional) |
+| hive.server2.proxy.user | the proxy user to impersonate | String(optional) |
+
+### GET /admin/engine
+
+Get a list of engines.

Review Comment:
   Get a list of satisfied engines.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] Yikf commented on a diff in pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/list engine operation

Posted by GitBox <gi...@apache.org>.
Yikf commented on code in PR #3689:
URL: https://github.com/apache/incubator-kyuubi/pull/3689#discussion_r1004037243


##########
docs/client/rest/rest_api.md:
##########
@@ -349,6 +349,43 @@ Gets the local log lines from this batch.
 | logRowSet | The log lines     | List of sting |
 | rowCount  | The log row count | Int           |
 
+## Admin Resource
+
+### POST /admin/refresh/hadoop_conf
+
+Refresh the Kyuubi server hadoop conf, and return the success message.

Review Comment:
   Can simplifies to `Refresh the Kyuubi server hadoop conf` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/list engine operation

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3689:
URL: https://github.com/apache/incubator-kyuubi/pull/3689#discussion_r1004087804


##########
docs/tools/kyuubi-admin.rst:
##########
@@ -69,3 +69,51 @@ Usage: ``bin/kyuubi-admin refresh config [options] [<configType>]``
      - Description
    * - hadoopConf
      - The hadoop conf used for proxy user verification.
+
+.. _list_engine:
+
+List Engine

Review Comment:
   List Engines



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] lightning-L commented on pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/list engine operation

Posted by GitBox <gi...@apache.org>.
lightning-L commented on PR #3689:
URL: https://github.com/apache/incubator-kyuubi/pull/3689#issuecomment-1289894303

   <img width="1556" alt="image" src="https://user-images.githubusercontent.com/21362040/197668292-e524987b-35c5-4a77-8a6e-2b78326d1afc.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/list engine operation

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3689:
URL: https://github.com/apache/incubator-kyuubi/pull/3689#issuecomment-1289155839

   # [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3689?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#3689](https://codecov.io/gh/apache/incubator-kyuubi/pull/3689?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c2226f) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/c25961ea0271ea38e67e046fc3696605df2958b8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c25961e) will **decrease** coverage by `0.02%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3689      +/-   ##
   ============================================
   - Coverage     52.29%   52.26%   -0.03%     
     Complexity       13       13              
   ============================================
     Files           489      489              
     Lines         27425    27425              
     Branches       3814     3814              
   ============================================
   - Hits          14342    14335       -7     
   - Misses        11707    11708       +1     
   - Partials       1376     1382       +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3689?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `79.45% <0.00%> (-2.74%)` | :arrow_down: |
   | [...pache/kyuubi/engine/YarnApplicationOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvWWFybkFwcGxpY2F0aW9uT3BlcmF0aW9uLnNjYWxh) | `62.96% <0.00%> (-1.86%)` | :arrow_down: |
   | [.../engine/spark/session/SparkSQLSessionManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUva3l1dWJpL2VuZ2luZS9zcGFyay9zZXNzaW9uL1NwYXJrU1FMU2Vzc2lvbk1hbmFnZXIuc2NhbGE=) | `78.48% <0.00%> (-1.27%)` | :arrow_down: |
   | [...n/scala/org/apache/kyuubi/engine/ProcBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvUHJvY0J1aWxkZXIuc2NhbGE=) | `80.74% <0.00%> (-0.63%)` | :arrow_down: |
   | [...a/org/apache/kyuubi/service/TFrontendService.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2aWNlL1RGcm9udGVuZFNlcnZpY2Uuc2NhbGE=) | `91.17% <0.00%> (-0.30%)` | :arrow_down: |
   | [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3689/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `97.30% <0.00%> (-0.08%)` | :arrow_down: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei closed pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/list engine operation

Posted by GitBox <gi...@apache.org>.
turboFei closed pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/list engine operation
URL: https://github.com/apache/incubator-kyuubi/pull/3689


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] lightning-L commented on pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/li…

Posted by GitBox <gi...@apache.org>.
lightning-L commented on PR #3689:
URL: https://github.com/apache/incubator-kyuubi/pull/3689#issuecomment-1288955632

   @turboFei 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] lightning-L commented on a diff in pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/list engine operation

Posted by GitBox <gi...@apache.org>.
lightning-L commented on code in PR #3689:
URL: https://github.com/apache/incubator-kyuubi/pull/3689#discussion_r1004106173


##########
docs/client/rest/rest_api.md:
##########
@@ -349,6 +349,43 @@ Gets the local log lines from this batch.
 | logRowSet | The log lines     | List of sting |
 | rowCount  | The log row count | Int           |
 
+## Admin Resource
+
+### POST /admin/refresh/hadoop_conf
+
+Refresh the Kyuubi server hadoop conf.
+
+### DELETE /admin/engine
+
+Delete specified engine.

Review Comment:
   yes, delete operation will delete an engine at a time. When the parameter is not specified, we will read the value from Kyuubi conf. For subdomain, if it is empty, we will use "default". Then we could construct the zk path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] lightning-L commented on pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/list engine operation

Posted by GitBox <gi...@apache.org>.
lightning-L commented on PR #3689:
URL: https://github.com/apache/incubator-kyuubi/pull/3689#issuecomment-1289893973

   <img width="1413" alt="image" src="https://user-images.githubusercontent.com/21362040/197667408-679b940d-d217-473a-8131-7fe106faa8c5.png">
   <img width="1370" alt="image" src="https://user-images.githubusercontent.com/21362040/197667453-2ad673f8-286c-4031-a804-8d354ce688b2.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/list engine operation

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3689:
URL: https://github.com/apache/incubator-kyuubi/pull/3689#discussion_r1004091002


##########
docs/tools/kyuubi-admin.rst:
##########
@@ -69,3 +69,51 @@ Usage: ``bin/kyuubi-admin refresh config [options] [<configType>]``
      - Description
    * - hadoopConf
      - The hadoop conf used for proxy user verification.
+
+.. _list_engine:
+
+List Engine
+-------------------------------------
+
+Prints a table of the key information about the specified engines.
+
+Usage: ``bin/kyuubi-admin list engine [options]``
+
+.. list-table::
+   :widths: 20 80
+   :header-rows: 1
+
+   * - Options
+     - Description
+   * - -et, --engine-type
+     - The engine type. If not specified, it will read the configuration item kyuubi.engine.type from kyuubi-defaults.conf.
+   * - -esl, --engine-share-level
+     - The engine share level. If not specified, it will read the configuration item kyuubi.engine.share.level from kyuubi-defaults.conf.
+   * - -es, --engine-subdomain
+     - The subdomain for the share level of an engine. If not specified, it will read the configuration item kyuubi.engine.share.level.subdomain from kyuubi-defaults.conf.
+   * - --hs2ProxyUser
+     - The proxy user to impersonate. When specified, it will list engines for the hs2ProxyUser.
+
+.. _delete_engine:
+
+Delete Engine

Review Comment:
   Delete an Engine



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/list engine operation

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3689:
URL: https://github.com/apache/incubator-kyuubi/pull/3689#discussion_r1004137184


##########
docs/client/rest/rest_api.md:
##########
@@ -349,6 +349,43 @@ Gets the local log lines from this batch.
 | logRowSet | The log lines     | List of sting |
 | rowCount  | The log row count | Int           |
 
+## Admin Resource
+
+### POST /admin/refresh/hadoop_conf
+
+Refresh the Kyuubi server hadoop conf.
+
+### DELETE /admin/engine
+
+Delete specified engine.

Review Comment:
   it's better to add the explanation above to the doc.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] turboFei commented on pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/list engine operation

Posted by GitBox <gi...@apache.org>.
turboFei commented on PR #3689:
URL: https://github.com/apache/incubator-kyuubi/pull/3689#issuecomment-1290413612

   thanks @lightning-L , @Yikf @yaooqinn , merging to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/list engine operation

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3689:
URL: https://github.com/apache/incubator-kyuubi/pull/3689#discussion_r1004085808


##########
docs/client/rest/rest_api.md:
##########
@@ -349,6 +349,43 @@ Gets the local log lines from this batch.
 | logRowSet | The log lines     | List of sting |
 | rowCount  | The log row count | Int           |
 
+## Admin Resource
+
+### POST /admin/refresh/hadoop_conf
+
+Refresh the Kyuubi server hadoop conf.
+
+### DELETE /admin/engine
+
+Delete specified engine.

Review Comment:
   Delete the specified engine.
   
   BTW, can we accurately delete the specified engine by the following parameters?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/list engine operation

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3689:
URL: https://github.com/apache/incubator-kyuubi/pull/3689#discussion_r1004090621


##########
docs/client/rest/rest_api.md:
##########
@@ -386,3 +423,15 @@ Gets the local log lines from this batch.
 | totalOperations | How many queries and meta calls                                                                                     | Int       |
 | exception       | The session exception, such as the exception that occur when opening session                                        | Throwable |
 | eventType       | The type of session event                                                                                           | String    |
+
+### Engine
+
+| Name           | Description                                              | Type   |
+| :------------- |:---------------------------------------------------------| :----- |
+| version        | The kyuubi version                                       | String |

Review Comment:
   the version of the Kyuubi server that creates this engine instance



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org


[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3689: [KYUUBI #3688] add rest_api and kyuubi-admin docs for admin delete/list engine operation

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3689:
URL: https://github.com/apache/incubator-kyuubi/pull/3689#discussion_r1004083863


##########
docs/client/rest/rest_api.md:
##########
@@ -349,6 +349,43 @@ Gets the local log lines from this batch.
 | logRowSet | The log lines     | List of sting |
 | rowCount  | The log row count | Int           |
 
+## Admin Resource
+
+### POST /admin/refresh/hadoop_conf
+
+Refresh the Kyuubi server hadoop conf.

Review Comment:
   Refresh the Hadoop configurations of the Kyuubi server.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org