You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2015/05/13 02:49:00 UTC
Review Request 34145: unable to see complete non-master node name at
step 6 (Assign Slaves and Clients) if more than 23 characters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34145/
-----------------------------------------------------------
Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-11091
https://issues.apache.org/jira/browse/AMBARI-11091
Repository: ambari
Description
-------
When you reach step 6 i.e. Assign Slaves and Clients, If your node name is more than 23 characters (with internal domain name, for most cluster it would be), it is not possible to find out complete name of non-master nodes even after hovering mouse over it. Hence it becomes difficult to install mix and match of slave and client components to desired hosts which are non-master.
Diffs
-----
ambari-web/app/views/wizard/step6_view.js 4efea53
ambari-web/test/views/wizard/step6_view_test.js 81628d8
Diff: https://reviews.apache.org/r/34145/diff/
Testing
-------
tested on a live cluster
Modifeied the existing unit test, verified all unit test passes
Thanks,
Jaimin Jetly
Re: Review Request 34145: unable to see complete non-master node name
at step 6 (Assign Slaves and Clients) if more than 23 characters
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34145/#review83537
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On May 13, 2015, 12:49 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34145/
> -----------------------------------------------------------
>
> (Updated May 13, 2015, 12:49 a.m.)
>
>
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-11091
> https://issues.apache.org/jira/browse/AMBARI-11091
>
>
> Repository: ambari
>
>
> Description
> -------
>
> When you reach step 6 i.e. Assign Slaves and Clients, If your node name is more than 23 characters (with internal domain name, for most cluster it would be), it is not possible to find out complete name of non-master nodes even after hovering mouse over it. Hence it becomes difficult to install mix and match of slave and client components to desired hosts which are non-master.
>
>
> Diffs
> -----
>
> ambari-web/app/views/wizard/step6_view.js 4efea53
> ambari-web/test/views/wizard/step6_view_test.js 81628d8
>
> Diff: https://reviews.apache.org/r/34145/diff/
>
>
> Testing
> -------
>
> tested on a live cluster
> Modifeied the existing unit test, verified all unit test passes
>
>
> Thanks,
>
> Jaimin Jetly
>
>