You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "klion26 (via GitHub)" <gi...@apache.org> on 2025/01/21 03:43:35 UTC

[PR] [AMORO-3404] Correct the description about MySQL usage [amoro-site]

klion26 opened a new pull request, #48:
URL: https://github.com/apache/amoro-site/pull/48

   The lincense of MySQL is incompatible with Apache Lincese, we need to correct the descriptions
   
   This closes apache/amoro#3403


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AMORO-3404] Correct the description about MySQL usage [amoro-site]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #48:
URL: https://github.com/apache/amoro-site/pull/48


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AMORO-3404] Correct the description about MySQL usage [amoro-site]

Posted by "klion26 (via GitHub)" <gi...@apache.org>.
klion26 commented on PR #48:
URL: https://github.com/apache/amoro-site/pull/48#issuecomment-2603597295

   @justinmclean @zhoujinsong please help to review this when you're free, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AMORO-3404] Correct the description about MySQL usage [amoro-site]

Posted by "klion26 (via GitHub)" <gi...@apache.org>.
klion26 commented on PR #48:
URL: https://github.com/apache/amoro-site/pull/48#issuecomment-2603726430

   @zhoujinsong comments have been addressed, please take another look when you're free, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [AMORO-3404] Correct the description about MySQL usage [amoro-site]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on code in PR #48:
URL: https://github.com/apache/amoro-site/pull/48#discussion_r1923039793


##########
amoro-docs/content/admin-guides/deployment.md:
##########
@@ -99,38 +98,25 @@ Make sure the port is not used before configuring it.
 
 ### Configure system database
 
-You can use MySQL/PostgreSQL as the system database instead of the default Derby.
+Amoro used `Derby` as the backend storage default, so you can use `Derby` directly without any additional configuration. 

Review Comment:
   ```suggestion
   Ams uses embedded [Apache Derby](https://db.apache.org/derby/) as the backend storage by default, so you can use `Derby` directly without any additional configuration. 
   ```



##########
amoro-docs/content/admin-guides/deployment-on-kubernetes.md:
##########
@@ -157,16 +157,16 @@ ingress:
 ### Configure the database.
 
 AMS default is to use Derby database for storage. When the pod is destroyed, the data will also disappear.
-In production environments, we recommend using MySQL as the storage for system data.
+In production environments, we recommend using a RDBMS as the storage for system data, you can ref to [Database Configuration](/deployment/#configure-system-database) for more detail.

Review Comment:
   As far as I know, Derby can also be deployed independently to improve its availability.
   
   So we may change the content here like:
   ```
   AMS uses embedded [Apache Derby](https://db.apache.org/derby/) as its backend storage by default.
   In production environments, we recommend using an RDBMS(Relational Database Management System) with higher availability guarantees as the storage for system data, you can refer to [Database Configuration](/deployment/#configure-system-database) for more details.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org