You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@helix.apache.org by GitBox <gi...@apache.org> on 2019/07/22 23:05:05 UTC

[GitHub] [helix] pkuwm commented on issue #353: Don't ignore exceptions: adding log messages to help check exceptions.

pkuwm commented on issue #353: Don't ignore exceptions: adding log messages to help check exceptions.
URL: https://github.com/apache/helix/issues/353#issuecomment-513987724
 
 
   Thanks for the explanation! I understand what the code is doing. If the property is not a correct type, it continues to check next one. My idea is if it is an exception, it should be handled properly, at least log the info to indicate the property/key is not a workflow type so it could be resolved.
   
   Anytime, the code above is just an example. There may be other places don’t handle all the exceptions. I propose this to handle exceptions properly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services