You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/01/20 14:48:42 UTC
[GitHub] [airflow] vemikhaylov opened a new pull request #13790: Add params to the DAG details endpoint
vemikhaylov opened a new pull request #13790:
URL: https://github.com/apache/airflow/pull/13790
closes: #13653
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vemikhaylov commented on pull request #13790: Add params to the DAG details endpoint
Posted by GitBox <gi...@apache.org>.
vemikhaylov commented on pull request #13790:
URL: https://github.com/apache/airflow/pull/13790#issuecomment-764352855
> > I decided to use the list of objects with "name" and "value" keys instead of the simple dictionary dumping
>
> This is interesting idea, but I think it makes sense for this parameter to follow the conf structure so you can fetch the params object, modify some fields and then pass them to the trigger DAG Run endpoint without additional transformations.
Makes sense. Fixed it up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13790: Add params to the DAG details endpoint
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13790:
URL: https://github.com/apache/airflow/pull/13790#issuecomment-764732245
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13790: Add params to the DAG details endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13790:
URL: https://github.com/apache/airflow/pull/13790#issuecomment-763922895
> I decided to use the list of objects with "name" and "value" keys instead of the simple dictionary dumping
This is interesting idea, but I think it makes sense for this parameter to follow the conf structure so you can fetch the params object, modify some fields and then pass them to the trigger DAG Run endpoint without additional transformations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vemikhaylov commented on pull request #13790: Add params to the DAG details endpoint
Posted by GitBox <gi...@apache.org>.
vemikhaylov commented on pull request #13790:
URL: https://github.com/apache/airflow/pull/13790#issuecomment-763702992
I decided to use the list of objects with "name" and "value" keys instead of the simple dictionary dumping for the following reasons:
1) It's more extensible. For instance, we might want to add description for parameters in the future anyhow, this structure allows us to do so.
2) It's more consistent with some other entities in the API like `Config`, where `ConfigOption` is represented in the same fashion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13790: Add params to the DAG details endpoint
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13790:
URL: https://github.com/apache/airflow/pull/13790#issuecomment-763660366
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #13790: Add params to the DAG details endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13790:
URL: https://github.com/apache/airflow/pull/13790
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #13790: Add params to the DAG details endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #13790:
URL: https://github.com/apache/airflow/pull/13790#issuecomment-763922895
> I decided to use the list of objects with "name" and "value" keys instead of the simple dictionary dumping
This is interesting idea, but I think it makes sense for this parameter to follow the conf structure so you can fetch the params object, modify some fields and then pass them to the trigger DAG Run endpoint without additional transformations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] vemikhaylov commented on pull request #13790: Add params to the DAG details endpoint
Posted by GitBox <gi...@apache.org>.
vemikhaylov commented on pull request #13790:
URL: https://github.com/apache/airflow/pull/13790#issuecomment-764352855
> > I decided to use the list of objects with "name" and "value" keys instead of the simple dictionary dumping
>
> This is interesting idea, but I think it makes sense for this parameter to follow the conf structure so you can fetch the params object, modify some fields and then pass them to the trigger DAG Run endpoint without additional transformations.
Makes sense. Fixed it up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj merged pull request #13790: Add params to the DAG details endpoint
Posted by GitBox <gi...@apache.org>.
mik-laj merged pull request #13790:
URL: https://github.com/apache/airflow/pull/13790
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #13790: Add params to the DAG details endpoint
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #13790:
URL: https://github.com/apache/airflow/pull/13790#issuecomment-764732245
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org