You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/08/16 12:53:49 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #4362: [Bug] Fix bug and improve compatibility with mysql protocol
morningman opened a new pull request #4362:
URL: https://github.com/apache/incubator-doris/pull/4362
## Proposed changes
1. select database() will only return database name, without cluster name. #4361
2. select user() will return the IP which user connected in. #4360
## Types of changes
- [x] Bugfix (non-breaking change which fixes an issue)
## Checklist
- [x] I have create an issue on (Fix #4361 #4360 ), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #4362: [MySQL Compatibility 2/4][Bug] Fix bug and improve compatibility with mysql protocol
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #4362:
URL: https://github.com/apache/incubator-doris/pull/4362#discussion_r473781656
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/InformationFunction.java
##########
@@ -75,3 +80,5 @@ public String toSqlImpl() {
return funcType + "()";
}
}
+
+
Review comment:
two empty lines？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4362: [MySQL Compatibility 2/4][Bug] Fix bug and improve compatibility with mysql protocol
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4362:
URL: https://github.com/apache/incubator-doris/pull/4362
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #4362: [MySQL Compatibility 2/4][Bug] Fix bug and improve compatibility with mysql protocol
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #4362:
URL: https://github.com/apache/incubator-doris/pull/4362#discussion_r473822913
##########
File path: fe/fe-core/src/main/java/org/apache/doris/analysis/InformationFunction.java
##########
@@ -75,3 +80,5 @@ public String toSqlImpl() {
return funcType + "()";
}
}
+
+
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org