You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/11 20:07:11 UTC
[jira] [Commented] (BEAM-399) SerializableCoder.equals does not
handle null
[ https://issues.apache.org/jira/browse/BEAM-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371507#comment-15371507 ]
ASF GitHub Bot commented on BEAM-399:
-------------------------------------
GitHub user ilganeli opened a pull request:
https://github.com/apache/incubator-beam/pull/627
[BEAM-399] Updated the SerializableCoder class to fix equals method to handle nulls.
* Equals method now checks for null
* Added test to check for null equals
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ilganeli/incubator-beam BEAM-399
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-beam/pull/627.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #627
----
commit 79345d809409fd9bf9f8a7ca0a4719487006b026
Author: Ilya Ganelin <il...@capitalone.com>
Date: 2016-07-11T20:05:51Z
Fixed equals method to handle null and added respective test.
----
> SerializableCoder.equals does not handle null
> ---------------------------------------------
>
> Key: BEAM-399
> URL: https://issues.apache.org/jira/browse/BEAM-399
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Scott Wegner
> Priority: Minor
> Labels: findbugs, newbie, starter
>
> [FindBugs NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml#L100]: equals() method does not check for null argument
> Applies to: [SerializableCoder|https://github.com/apache/incubator-beam/blob/58a029a06aea1030279e5da8f9fa3114f456c1db/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/SerializableCoder.java].
> This is a good starter bug. When fixing, please remove the corresponding entries from [findbugs-filter.xml|https://github.com/apache/incubator-beam/blob/master/sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml] and verify the build passes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)