[jira] [Commented] (OFBIZ-10934) Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-10934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17615175#comment-17615175 ] 

ASF subversion and git services commented on OFBIZ-10934:
---------------------------------------------------------

Commit 83c2637d2e8ef22575ddd63aeb9af19ecbe7eb13 in ofbiz-framework's branch refs/heads/trunk from Jacques Le Roux
[ https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=83c2637d2e ]

Improved: Use replace() instead of replaceAll() when a regex is not used (OFBIZ-10934)

Increases performance and clarify usage of replaceAll()

Thanks: bd2019us, whoever he is, for the suggestion (patches were outdated)


> Performance Increase: Using replace() instead of replaceAll() when a regex is not used increases performance
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-10934
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-10934
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk, Upcoming Branch
>            Reporter: bd2019us
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>              Labels: performance
>         Attachments: OFBIZ-10934.patch, OFBIZ10934-MORE.patch, affected_files
>
>
> Affected files:
> # framework/base/src/main/java/org/apache/ofbiz/base/util/UtilHttp.java
> # framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
> # framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java
> # framework/base/src/main/java/org/apache/ofbiz/base/util/KeyStoreUtil.java 
> When replaceAll() is utilized and no regex is used, replaceAll() can be replaced with replace() for better performance.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)