You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/02/09 13:00:53 UTC
[GitHub] [spark] bozhang2820 opened a new pull request #35462: [SPARK-31709][SQL][FOLLOWUP] Treat table location as absolute when the first letter of its path is slash in create/alter table
bozhang2820 opened a new pull request #35462:
URL: https://github.com/apache/spark/pull/35462
### What changes were proposed in this pull request?
This is a follow-up of https://github.com/apache/spark/pull/28527, in which we change to create table under the database location when the table location is relative. However the criteria to determine if a table location is relative/absolute is `URI.isAbsolute`, which basically checks if the table location URI has a scheme defined. So table URIs like `/table/path` are treated as relative and the scheme and authority of the database location URI are used to create the table. For example, when the database location URI is `s3a://bucket/db`, the table will be created at `s3a://bucket/table/path`, while it should be created under the file system defined in `SessionCatalog.hadoopConf`.
This change fixes that by treating table location as absolute when the first letter of its path is slash.
This also applies to alter table.
### Why are the changes needed?
This is to fix the behavior described above.
### Does this PR introduce _any_ user-facing change?
Yes. When users try to create/alter table with a location that starts with a slash but without scheme defined, the table will be created under / altered to the file system defined in `SessionCatalog.hadoopConf`, instead of the one defined in database location URI.
### How was this patch tested?
Updated unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bozhang2820 commented on pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
bozhang2820 commented on pull request #35462:
URL: https://github.com/apache/spark/pull/35462#issuecomment-1042691172
Thanks @dongjoon-hyun for the guidance. Created https://issues.apache.org/jira/browse/SPARK-38236 and updated the title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bozhang2820 commented on pull request #35462: [SPARK-31709][SQL][FOLLOWUP] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
bozhang2820 commented on pull request #35462:
URL: https://github.com/apache/spark/pull/35462#issuecomment-1041183533
CC @yaooqinn @cloud-fan for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #35462:
URL: https://github.com/apache/spark/pull/35462#discussion_r808905663
##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -53,15 +53,11 @@ import org.apache.spark.sql.types._
import org.apache.spark.sql.v2.avro.AvroScan
import org.apache.spark.util.Utils
-abstract class AvroSuite
+abstract class AvroSuiteBase
Review comment:
but certain test case can reset the hadoop configs it sets to avoid polluting the shared environment, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bozhang2820 edited a comment on pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
bozhang2820 edited a comment on pull request #35462:
URL: https://github.com/apache/spark/pull/35462#issuecomment-1046484120
Created https://github.com/apache/spark/pull/35591 for 3.2.
It seems that it can be merged to 3.1 cleanly. Should I create one for 3.1? Also should I add "[3.2]" in the PR title in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zsxwing commented on a change in pull request #35462: [WIP][SPARK-31709][SQL][FOLLOWUP] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
zsxwing commented on a change in pull request #35462:
URL: https://github.com/apache/spark/pull/35462#discussion_r804424593
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -388,6 +388,8 @@ class SessionCatalog(
private def makeQualifiedTablePath(locationUri: URI, database: String): URI = {
if (locationUri.isAbsolute) {
locationUri
+ } else if (locationUri.getPath.startsWith("/")) {
Review comment:
Use `new Path(locationUri).isAbsolute`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bozhang2820 commented on a change in pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
bozhang2820 commented on a change in pull request #35462:
URL: https://github.com/apache/spark/pull/35462#discussion_r808860959
##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -53,15 +53,11 @@ import org.apache.spark.sql.types._
import org.apache.spark.sql.v2.avro.AvroScan
import org.apache.spark.util.Utils
-abstract class AvroSuite
+abstract class AvroSuiteBase
Review comment:
It's because `SparkContext.hadoopConfiguration` is passed to `org.apache.hadoop.fs.Path.getFileSystem()` and that is shared across tests in the same suite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bozhang2820 commented on a change in pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
bozhang2820 commented on a change in pull request #35462:
URL: https://github.com/apache/spark/pull/35462#discussion_r808648712
##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -53,15 +53,11 @@ import org.apache.spark.sql.types._
import org.apache.spark.sql.v2.avro.AvroScan
import org.apache.spark.util.Utils
-abstract class AvroSuite
+abstract class AvroSuiteBase
Review comment:
After running the test in `CommonFileDataSourceSuite`, `org.apache.hadoop.fs.Path.getFileSystem()` in other tests in the same suite will fail the check in `FakeFileSystemRequiringDSOption`, since they share the same `SparkSession`.
That's why I split the suites that extends `CommonFileDataSourceSuite` into separate ones in this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bozhang2820 commented on a change in pull request #35462: [WIP][SPARK-31709][SQL][FOLLOWUP] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
bozhang2820 commented on a change in pull request #35462:
URL: https://github.com/apache/spark/pull/35462#discussion_r805504254
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -388,6 +388,8 @@ class SessionCatalog(
private def makeQualifiedTablePath(locationUri: URI, database: String): URI = {
if (locationUri.isAbsolute) {
locationUri
+ } else if (locationUri.getPath.startsWith("/")) {
Review comment:
Thanks! Will change to follow your suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #35462:
URL: https://github.com/apache/spark/pull/35462#issuecomment-1047275373
+1, late LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bozhang2820 commented on a change in pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
bozhang2820 commented on a change in pull request #35462:
URL: https://github.com/apache/spark/pull/35462#discussion_r810441367
##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -68,6 +68,8 @@ abstract class AvroSuite
override protected def beforeAll(): Unit = {
super.beforeAll()
+ // initialize SessionCatalog here so it has a clean hadoopConf
+ spark.sessionState.catalog
Review comment:
I thought about it but figured that might need a separate PR due to the impact?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bozhang2820 commented on pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
bozhang2820 commented on pull request #35462:
URL: https://github.com/apache/spark/pull/35462#issuecomment-1046484120
Created https://github.com/apache/spark/pull/35591 for 3.2.
It seems that it can merge to 3.1 cleanly. Should I create one for 3.1? Also should I add "[3.2]" in the PR title in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gatorsmile commented on a change in pull request #35462: [WIP][SPARK-31709][SQL][FOLLOWUP] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
gatorsmile commented on a change in pull request #35462:
URL: https://github.com/apache/spark/pull/35462#discussion_r803881804
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
##########
@@ -388,6 +388,8 @@ class SessionCatalog(
private def makeQualifiedTablePath(locationUri: URI, database: String): URI = {
if (locationUri.isAbsolute) {
locationUri
+ } else if (locationUri.getPath.startsWith("/")) {
+ makeQualifiedPath(locationUri)
Review comment:
cc @zsxwing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #35462:
URL: https://github.com/apache/spark/pull/35462#discussion_r810094742
##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -68,6 +68,8 @@ abstract class AvroSuite
override protected def beforeAll(): Unit = {
super.beforeAll()
+ // initialize SessionCatalog here so it has a clean hadoopConf
+ spark.sessionState.catalog
Review comment:
shall we do it in `SharedSparkSessionBase.initializeSession`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #35462:
URL: https://github.com/apache/spark/pull/35462#issuecomment-1046438350
thanks, merging to master/3.2!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bozhang2820 commented on a change in pull request #35462: [SPARK-31709][SQL][FOLLOWUP] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
bozhang2820 commented on a change in pull request #35462:
URL: https://github.com/apache/spark/pull/35462#discussion_r808648712
##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -53,15 +53,11 @@ import org.apache.spark.sql.types._
import org.apache.spark.sql.v2.avro.AvroScan
import org.apache.spark.util.Utils
-abstract class AvroSuite
+abstract class AvroSuiteBase
Review comment:
After running the test in `CommonFileDataSourceSuite`, `org.apache.hadoop.fs.Path.getFileSystem()` in other tests in the same suite will fail the check in `FakeFileSystemRequiringDSOption`, since they share the same `SparkContext`.
That's why I split the suites that extends `CommonFileDataSourceSuite` into separate ones in this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #35462:
URL: https://github.com/apache/spark/pull/35462#discussion_r808828913
##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -53,15 +53,11 @@ import org.apache.spark.sql.types._
import org.apache.spark.sql.v2.avro.AvroScan
import org.apache.spark.util.Utils
-abstract class AvroSuite
+abstract class AvroSuiteBase
Review comment:
is it because `org.apache.hadoop.fs.Path.getFileSystem()` has cache?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan edited a comment on pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
cloud-fan edited a comment on pull request #35462:
URL: https://github.com/apache/spark/pull/35462#issuecomment-1046438350
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #35462: [SPARK-31709][SQL][FOLLOWUP] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #35462:
URL: https://github.com/apache/spark/pull/35462#discussion_r808020568
##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -53,15 +53,11 @@ import org.apache.spark.sql.types._
import org.apache.spark.sql.v2.avro.AvroScan
import org.apache.spark.util.Utils
-abstract class AvroSuite
+abstract class AvroSuiteBase
Review comment:
why do we need to touch this suite? The fix is for catalog stuff and is not related to the file source.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bozhang2820 commented on a change in pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
bozhang2820 commented on a change in pull request #35462:
URL: https://github.com/apache/spark/pull/35462#discussion_r809040677
##########
File path: external/avro/src/test/scala/org/apache/spark/sql/avro/AvroSuite.scala
##########
@@ -53,15 +53,11 @@ import org.apache.spark.sql.types._
import org.apache.spark.sql.v2.avro.AvroScan
import org.apache.spark.util.Utils
-abstract class AvroSuite
+abstract class AvroSuiteBase
Review comment:
The test in `CommonFileDataSourceSuite` actually uses `withSQLConf` which does reset the config. However `SessionCatalog.hadoopConf` are set and could not be changed unless we create a new `SessionCatalog`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #35462:
URL: https://github.com/apache/spark/pull/35462#issuecomment-1046438878
@bozhang2820 can you help to create backport PRs for 3.2 and 3.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #35462:
URL: https://github.com/apache/spark/pull/35462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] bozhang2820 edited a comment on pull request #35462: [SPARK-38236][SQL] Treat table location as absolute when the first letter of its path is slash in create/alter table
Posted by GitBox <gi...@apache.org>.
bozhang2820 edited a comment on pull request #35462:
URL: https://github.com/apache/spark/pull/35462#issuecomment-1046484120
Created https://github.com/apache/spark/pull/35591 for 3.1 and 3.2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org