You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by caofangkun <gi...@git.apache.org> on 2014/11/05 10:01:01 UTC
[GitHub] storm pull request: STORM-548:Receive Thread Shutdown hook should ...
GitHub user caofangkun opened a pull request:
https://github.com/apache/storm/pull/307
STORM-548:Receive Thread Shutdown hook should connect to local-hostname ...
backtype.storm.messaging.loader#launch-receive-thread!
kill-socket should connect to local hostname but not "localhost"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/caofangkun/apache-storm storm-548
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/307.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #307
----
commit f9707b58e7664a0618776bea91402b895541ab00
Author: caofangkun <ca...@gmail.com>
Date: 2014-11-05T08:56:40Z
STORM-548:Receive Thread Shutdown hook should connect to local-hostname but not localhost
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-548:Receive Thread Shutdown hook should ...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/307#issuecomment-64143486
+1 @caofangkun can you please upmerge this PR. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-548:Receive Thread Shutdown hook should ...
Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:
https://github.com/apache/storm/pull/307#issuecomment-61882471
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-548:Receive Thread Shutdown hook should ...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/307#issuecomment-67105369
@caofangkun I am trying to merge this into master but looks like your PR contains additional file loader.clj~ . can you please remove and update the PR. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-548:Receive Thread Shutdown hook should ...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/307#issuecomment-67111034
@caofangkun Thanks for the quick fix. I merged the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-548:Receive Thread Shutdown hook should ...
Posted by caofangkun <gi...@git.apache.org>.
Github user caofangkun commented on the pull request:
https://github.com/apache/storm/pull/307#issuecomment-67105973
@harshach I have removed additional file loader.clj~
please try to merge again ,thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-548:Receive Thread Shutdown hook should ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/307
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---