[jira] [Closed] (AIRFLOW-5851) Some urlparse and urlquote imports in V1-10 branch are python3-only

["Jarek Potiuk (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AIRFLOW-5851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jarek Potiuk closed AIRFLOW-5851.
---------------------------------
    Resolution: Won't Fix

Closing this one as we had to withdraw from isort for v1-10-test due to circular commits

I have done it once but forgot about it.

 

That reminds me one of the highest voted answer to this StackOverflow question:

[https://stackoverflow.com/questions/184618/what-is-the-best-comment-in-source-code-you-have-ever-encountered]

 
{code:java}
// 
// Dear maintainer:
// 
// Once you are done trying to 'optimize' this routine,
// and have realized what a terrible mistake that was,
// please increment the following counter as a warning
// to the next guy:
// 
// total_hours_wasted_here = 42
//  {code}

> Some urlparse and urlquote imports in V1-10 branch are python3-only
> -------------------------------------------------------------------
>
>                 Key: AIRFLOW-5851
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5851
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: contrib, core, operators
>    Affects Versions: 1.10.4, 1.10.5, 1.10.6
>            Reporter: Jarek Potiuk
>            Priority: Major
>
> Those files were affected:
>  * airflow/contrib/operators/gcp_cloud_build_operator.py
>  * airflow/models/connection.py
>  * airflow/contrib/hooks/databricks_hook.py
>  * airflow/contrib/operators/s3_to_sftp_operator.py
>  * airflow/contrib/operators/sftp_to_s3_operator.py
>  * airflow/sensors/s3_key_sensor.py
>  * airflow/utils/log/gcs_task_handler.py
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)