You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by shinrich <gi...@git.apache.org> on 2016/06/02 20:06:19 UTC
[GitHub] trafficserver pull request #694: TS-4503: Cause MachineFatal to terminate pr...
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/694
TS-4503: Cause MachineFatal to terminate process without attempting m\u2026
\u2026emory cleanup.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-4503
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/694.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #694
----
commit 465abad2f55fcac2f98af46ce3800ed8be43f36a
Author: Susan Hinrichs <sh...@ieee.org>
Date: 2016-06-02T20:04:37Z
TS-4503: Cause MachineFatal to terminate process without attempting memory cleanup.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #694: TS-4503: Cause MachineFatal to terminate process w...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/694
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/201/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #694: TS-4503: Cause MachineFatal to terminate process w...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/694
Testing again, this will blow up and I'm blaming @PSUdaemon [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #694: TS-4503: Cause MachineFatal to terminate process w...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/694
This somewhat defeats the fix in TS-4441. Rather than making fatal errors inconsistent, I think it is better to have the place that generates the error call ``ink_release_assert``.
We should also look into removing ``MachineFatal``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #694: TS-4503: Cause MachineFatal to terminate pr...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/694
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #694: TS-4503: Cause MachineFatal to terminate process w...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/694
Closing this PR. Will create a new one that replaces the use of MachineFatal with Fatal. I started this a couple weeks and it looks like we can remove all the *Fatal() functions with little effort. Unfortunately got distracted before I got that finished.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #694: TS-4503: Cause MachineFatal to terminate process w...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/694
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/308/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #694: TS-4503: Cause MachineFatal to terminate process w...
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/694
Testing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #694: TS-4503: Cause MachineFatal to terminate process w...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/694
Ok, I see you point. I have no love lost for MachineFatal. This is my first encounter with it. I'll try replacing it's use in ProtocolProbeSessionAccept with Fatal and add a ink_release_assert there.
Actually it just looks like it is used in the various Accept classes. I'll look at replacing all 5 instances and removing MachineFatal.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #694: TS-4503: Cause MachineFatal to terminate process w...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/694
But ``Fatal`` doesn't drop a core and it shouldn't so this should behave the same. I'm all for adding asserts near the root cause but I don't think we should drop core on managed errors, and really this whole ``Machine`` API adds little value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #694: TS-4503: Cause MachineFatal to terminate process w...
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/694
Testing, this will blow up and I'm blaming @PSUdaemon [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #694: TS-4503: Cause MachineFatal to terminate process w...
Posted by shinrich <gi...@git.apache.org>.
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/694
In our most recent fire drill, the core was very useful. The particular problem only happens under very heavy load. By poking around the core, we got some idea of the underlying cause and were able to add additional checks to attempt to catch the problem next time around.
The problem was that the reported stack was showing secondary errors from the memory cleanup. So we were looking in the wrong area for several days until we got access to the machine and core. Then staring at the core for a while until it occurred to me to do "info thread" and find the real problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #694: TS-4503: Cause MachineFatal to terminate process w...
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/694
If you need to explicitly dump core from somewhere you can use ``ink_abort``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---